fix: DB API depends on pyarrow when decimal query parameters are used #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DB API should gracefully handle the case when the optional pyarrow dependency is not installed.
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: bigquery
plamut
commented
Mar 15, 2021
tswast
requested changes
Mar 15, 2021
plamut
commented
Mar 16, 2021
Comment on lines
+192
to
201
| # NUMERIC values have precision of 38 (number of digits) and scale of 9 (number | ||
| # of fractional digits), and their max absolute value must be strictly smaller | ||
| # than 1.0E+29. | ||
| # https://cloud.google.com/bigquery/docs/reference/standard-sql/data-types#decimal_types | ||
| if ( | ||
| len(vtuple.digits) <= 38 # max precision: 38 | ||
| and vtuple.exponent >= -9 # max scale: 9 | ||
| and _NUMERIC_SERVER_MIN <= value <= _NUMERIC_SERVER_MAX | ||
| ): | ||
| return "NUMERIC" |
There was a problem hiding this comment.
The logic differs from the docs, because testing the actual backend response showed that 9.9999999999999999999999999999999999999E+29 is not accepted as a valid NUMERIC value:
SELECT CAST((SELECT "9.9999999999999999999999999999999999999E+29" AS literal) AS NUMERIC); # errorEven 1.0E+29 is too large, but 9.999...9E+28 works, meaning that there's probably an off-by-one error in the docs for the exponent.
Update: Confirmed, the docs are indeed not correct, an internal issue 182900100 has been created to track this.
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Mar 16, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [2.12.0](https://www.github.com/googleapis/python-bigquery/compare/v2.11.0...v2.12.0) (2021-03-16) ### Features * make QueryJob.done() method more performant ([#544](https://www.github.com/googleapis/python-bigquery/issues/544)) ([a3ab9ef](https://www.github.com/googleapis/python-bigquery/commit/a3ab9efdd0758829845cfcb6ca0ac1f03ab44f64)) ### Bug Fixes * remove DB-API dependency on pyarrow with decimal query parameters ([#551](https://www.github.com/googleapis/python-bigquery/issues/551)) ([1b946ba](https://www.github.com/googleapis/python-bigquery/commit/1b946ba23ee7df86114c6acb338ec34e6c92af6d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
plamut
commented
Mar 16, 2021
| @@ -71,6 +72,33 @@ def test_scalar_to_query_parameter(self): | |||
| self.assertEqual(named_parameter.type_, expected_type, msg=msg) | |||
| self.assertEqual(named_parameter.value, value, msg=msg) | |||
|
|
|||
| def test_decimal_to_query_parameter(self): # TODO: merge with previous test | |||
There was a problem hiding this comment.
I should have removed that, it's just a subset of the test_scalar_to_query_parameter test above it.
4 tasks
This was referenced Mar 17, 2021
Merged
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #549.
This PR removes the hard dependency of DB API on the optional
pyarrowdependency.PR checklist: