Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use native support for namespace packages #313

Closed
tswast opened this issue Oct 8, 2020 · 2 comments · Fixed by #1726
Closed

use native support for namespace packages #313

tswast opened this issue Oct 8, 2020 · 2 comments · Fixed by #1726
Assignees
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@tswast
Copy link
Contributor

tswast commented Oct 8, 2020

Per: googleapis/google-auth-library-python#595 (comment)

It looks like different Google API packages have different approaches to using or not using pkg_resources here; e.g. https://github.com/googleapis/python-cloudbuild uses native NS packages and https://github.com/googleapis/python-bigquery uses pkg_resources with a pkgutil fallback.

Now that Python 2.7 and 3.5 support has been dropped, we may be able to follow the example in python-cloudbuild

@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Oct 8, 2020
@tswast tswast added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed api: bigquery Issues related to the googleapis/python-bigquery API. labels Oct 8, 2020
@tseaver
Copy link
Contributor

tseaver commented Oct 13, 2020

Something in my memory is niggling at me about doing this change incrementally: we need to test that a native namespace google-cloud-bigquery can be installed safely alongside our current mixed-mode google-auth / google-resumable-media / google-api-core / google-cloud-core.

@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Oct 22, 2020
@chalmerlowe chalmerlowe added the priority: p3 Desirable enhancement or fix. May not be included in next release. label Mar 31, 2023
@meredithslota
Copy link
Contributor

The GAPIC libraries dropped pkg_resources in Oct. 2022 here: googleapis/gapic-generator-python#1471 so we should consider doing the same for consistency. I believe @chalmerlowe was interested in working on this across the libraries that still need this done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
5 participants