feat: adds StorageDescriptor and tests #2109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: bigquery
tswast
reviewed
Jan 13, 2025
google/cloud/bigquery/schema.py
Outdated
Comment on lines
653
to
665
| inputFormat (Optional[str]): Specifies the fully qualified class name of | ||
| the InputFormat (e.g. | ||
| "org.apache.hadoop.hive.ql.io.orc.OrcInputFormat"). The maximum | ||
| length is 128 characters. | ||
| locationUri (Optional[str]): The physical location of the table (e.g. | ||
| 'gs://spark-dataproc-data/pangea-data/case_sensitive/' or | ||
| 'gs://spark-dataproc-data/pangea-data/'). The maximum length is | ||
| 2056 bytes. | ||
| outputFormat (Optional[str]): Specifies the fully qualified class name | ||
| of the OutputFormat (e.g. | ||
| "org.apache.hadoop.hive.ql.io.orc.OrcOutputFormat"). The maximum | ||
| length is 128 characters. | ||
| serdeInfo (Union[SerDeInfo, dict, None]): Serializer and deserializer information. |
There was a problem hiding this comment.
Suggested change
| inputFormat (Optional[str]): Specifies the fully qualified class name of | |
| the InputFormat (e.g. | |
| "org.apache.hadoop.hive.ql.io.orc.OrcInputFormat"). The maximum | |
| length is 128 characters. | |
| locationUri (Optional[str]): The physical location of the table (e.g. | |
| 'gs://spark-dataproc-data/pangea-data/case_sensitive/' or | |
| 'gs://spark-dataproc-data/pangea-data/'). The maximum length is | |
| 2056 bytes. | |
| outputFormat (Optional[str]): Specifies the fully qualified class name | |
| of the OutputFormat (e.g. | |
| "org.apache.hadoop.hive.ql.io.orc.OrcOutputFormat"). The maximum | |
| length is 128 characters. | |
| serdeInfo (Union[SerDeInfo, dict, None]): Serializer and deserializer information. | |
| input_format (Optional[str]): Specifies the fully qualified class name of | |
| the InputFormat (e.g. | |
| "org.apache.hadoop.hive.ql.io.orc.OrcInputFormat"). The maximum | |
| length is 128 characters. | |
| location_uri (Optional[str]): The physical location of the table (e.g. | |
| 'gs://spark-dataproc-data/pangea-data/case_sensitive/' or | |
| 'gs://spark-dataproc-data/pangea-data/'). The maximum length is | |
| 2056 bytes. | |
| output_format (Optional[str]): Specifies the fully qualified class name | |
| of the OutputFormat (e.g. | |
| "org.apache.hadoop.hive.ql.io.orc.OrcOutputFormat"). The maximum | |
| length is 128 characters. | |
| serde_info (Union[SerDeInfo, dict, None]): Serializer and deserializer information. |
google/cloud/bigquery/schema.py
Outdated
| self._properties["outputFormat"] = value | ||
|
|
||
| @property | ||
| def serde_info(self) -> Union[SerDeInfo, dict, None]: |
There was a problem hiding this comment.
We'd never return a dict though, just SerDeInfo or None, right?
There was a problem hiding this comment.
resolved.
mypy sometimes gets confused by a setter that accepts A, B, C
when paired with a getter that can only return A, C.
I added a typing.cast() call on ~line 680 to help mypy out and added a comment at that point to explain 'why typing.cast?'
google/cloud/bigquery/schema.py
Outdated
|
|
||
| prop = _helpers._get_sub_prop(self._properties, ["serDeInfo"]) | ||
| if prop is not None: | ||
| prop = SerDeInfo("PLACEHOLDER").from_api_repr(prop) |
There was a problem hiding this comment.
from_api_repr should be a class method, so instance shouldn't be required.
Suggested change
| prop = SerDeInfo("PLACEHOLDER").from_api_repr(prop) | |
| prop = SerDeInfo.from_api_repr(prop) |
This was referenced Jan 21, 2025
chalmerlowe
added a commit
that referenced
this pull request
Jan 22, 2025
* feat: adds StorageDescriptor and tests * updates attr names, corrects type hinting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the StorageDescriptor class and the associated tests, plus minor tweaks to support both of those changes.