Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: preserve unknown fields from the REST API representation in SchemaField #2097

Merged
merged 5 commits into from
Dec 27, 2024
Merged

feat: preserve unknown fields from the REST API representation in SchemaField #2097

merged 5 commits into from
Dec 27, 2024
+105 −75

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Dec 27, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards simplifying #2081
Fixes #6 even more than it already was by avoiding even more copy operations.
🦕

@tswast tswast requested review from a team as code owners December 27, 2024 19:58
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery API. labels Dec 27, 2024
@tswast tswast requested review from chalmerlowe and Linchin and removed request for agrawal-siddharth December 27, 2024 20:09
@tswast tswast assigned chalmerlowe and unassigned Neenu1995 Dec 27, 2024
Linchin
Linchin approved these changes Dec 27, 2024
View reviewed changes
Copy link
Contributor

@Linchin Linchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@tswast tswast merged commit aaf1eb8 into main Dec 27, 2024
19 checks passed
@tswast tswast deleted the tswast-schemafield-refactor branch December 27, 2024 22:55
@tswast tswast changed the title feat: preserve unknown fields from the REST API representaton in SchemaField feat: preserve unknown fields from the REST API representation in SchemaField Dec 27, 2024
@release-please release-please bot mentioned this pull request Dec 26, 2024
Merged
@chalmerlowe chalmerlowe mentioned this pull request Jan 2, 2025
Merged
chalmerlowe pushed a commit that referenced this pull request Jan 2, 2025
@tswast @gcf-owl-bot @chalmerlowe
feat: preserve unknown fields from the REST API representation in `Sc…
e3f57a6 
…hemaField` (#2097)

* feat: preserve unknown fields from the REST API representaton in `SchemaField`

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* remove unnecessary variable

* remove unused private method

* fix pytype

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
@tswast tswast mentioned this pull request Jan 16, 2025
Closed
This was referenced Jan 21, 2025
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Linchin Linchin Linchin approved these changes

@chalmerlowe chalmerlowe Awaiting requested review from chalmerlowe

Assignees

@chalmerlowe chalmerlowe

Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BigQuery: complex repeated schema fields are slow
4 participants
@tswast @Linchin @chalmerlowe @Neenu1995