Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make compiled packages such as "grpc" and "proto-plus" optional extras #1431

Closed
tswast opened this issue Dec 8, 2022 · 0 comments · Fixed by #1721
Closed

Make compiled packages such as "grpc" and "proto-plus" optional extras #1431

tswast opened this issue Dec 8, 2022 · 0 comments · Fixed by #1721
Assignees
@kiraksi
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@tswast
Copy link
Contributor

tswast commented Dec 8, 2022

I believe proto-plus / protobuf / grpc packages were only needed for google.cloud.bigquery_v2. These modules have been deprecated and disconnected from the google.cloud.bigquery modules in version 3.x. I believe this means we can move those dependencies to "extras" (a.k.a. optional dependencies) and make our package lighter-weight by default.

Follow-up to https://github.com/googleapis/python-bigquery/pull/1282/files#discussion_r928022130 and https://github.com/googleapis/python-bigquery/pull/1282/files#discussion_r928022317
@tswast tswast added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Dec 8, 2022
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Dec 8, 2022
@tswast tswast mentioned this issue Dec 8, 2022
Merged
@chalmerlowe chalmerlowe added the priority: p3 Desirable enhancement or fix. May not be included in next release. label Aug 25, 2023
@kiraksi kiraksi self-assigned this Nov 7, 2023
@kiraksi kiraksi mentioned this issue Nov 13, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kiraksi kiraksi

Labels
api: bigquery Issues related to the googleapis/python-bigquery API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: move grpc, proto-plus and protobuf packages to extras kiraksi/python-bigquery
3 participants
@tswast @chalmerlowe @kiraksi