-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support using BIGQUERY_EMULATOR_HOST environment variable #1222
Merged
steffnay
merged 16 commits into
googleapis:main
from
abecerrilsalas:apb_feature_bq_emulator
Apr 28, 2022
Merged
feat: support using BIGQUERY_EMULATOR_HOST environment variable #1222
steffnay
merged 16 commits into
googleapis:main
from
abecerrilsalas:apb_feature_bq_emulator
Apr 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lsalas/python-bigquery into apb_feature_bq_emulator
…lsalas/python-bigquery into apb_feature_bq_emulator
product-auto-label
bot
added
size: s
Pull request size is small.
api: bigquery
Issues related to the googleapis/python-bigquery API.
labels
Apr 19, 2022
steffnay
suggested changes
Apr 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Just needing changes to variable naming and then the additional tests you have planned.
product-auto-label
bot
added
size: m
Pull request size is medium.
and removed
size: s
Pull request size is small.
labels
Apr 20, 2022
steffnay
reviewed
Apr 25, 2022
…lsalas/python-bigquery into apb_feature_bq_emulator
product-auto-label
bot
added
size: s
Pull request size is small.
and removed
size: m
Pull request size is medium.
labels
Apr 26, 2022
steffnay
changed the title
feat: bq emulator
feat: support using BIGQUERY_EMULATOR_HOST environment variable
Apr 28, 2022
steffnay
approved these changes
Apr 28, 2022
waltaskew
pushed a commit
to waltaskew/python-bigquery
that referenced
this pull request
Jul 20, 2022
…leapis#1222) * feat:adding emulator * apb_feature_bq_emulator_test * apb_feature_bq_emulator_variable_name_change * abecerrilsalas_feature_bq_emulator_typo_changes * feat:fixing var names and start of test * abecerrilsalas_feature_additional_tests * feat: testing update * feat: fixed failed lint test
abdelmegahedgoogle
pushed a commit
to abdelmegahedgoogle/python-bigquery
that referenced
this pull request
Apr 17, 2023
…leapis#1222) * feat:adding emulator * apb_feature_bq_emulator_test * apb_feature_bq_emulator_variable_name_change * abecerrilsalas_feature_bq_emulator_typo_changes * feat:fixing var names and start of test * abecerrilsalas_feature_additional_tests * feat: testing update * feat: fixed failed lint test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: bigquery
Issues related to the googleapis/python-bigquery API.
size: s
Pull request size is small.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Implemented a BIGQUERY_EMULATOR_HOST environment variable to be used to set the api_endpoint in the python-bigquery client constructor.
Why?
Users have requested this implementation (#1193). Currently there is no logic to check for the existence of a BIGQUERY_EMULATOR_HOST or some similar environment variable
How?
Logic was applied and code was changed in the _helpers.py and client.py files.
Fixes #1193 🦕