Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add mypy type checking #26

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

test: add mypy type checking #26

wants to merge 6 commits into from

Conversation

chelsea-lin
Copy link
Contributor

Fixes #13 🦕

@chelsea-lin chelsea-lin requested a review from tswast April 29, 2024 22:52
@chelsea-lin chelsea-lin requested review from a team as code owners April 29, 2024 22:52
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Apr 29, 2024
@product-auto-label product-auto-label bot added api: bigquery Issues related to the googleapis/python-bigquery-magics API. size: xs Pull request size is extra small. and removed size: s Pull request size is small. labels Apr 29, 2024
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_mypy branch from 6421f0a to 93bde0a Compare April 29, 2024 22:57
@product-auto-label product-auto-label bot added size: s Pull request size is small. size: xs Pull request size is extra small. and removed size: xs Pull request size is extra small. size: s Pull request size is small. labels Apr 29, 2024
@chelsea-lin chelsea-lin marked this pull request as draft April 29, 2024 23:06
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_mypy branch from b524c19 to ba6daff Compare April 29, 2024 23:07
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Apr 29, 2024
@chelsea-lin chelsea-lin marked this pull request as ready for review April 30, 2024 18:25
tswast
tswast requested changes Apr 30, 2024
View reviewed changes
noxfile.py Outdated
@@ -100,14 +100,15 @@

# 'docfx' is excluded since it only needs to run in 'docs-presubmit'
nox.options.sessions = [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a templated file. See: https://github.com/googleapis/synthtool/blob/master/synthtool/gcp/templates/python_library/noxfile.py.j2

Please update owlbot.py with this customization and/or update the template linked above.

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: s Pull request size is small. labels Apr 30, 2024
@GarrettWu GarrettWu removed their assignment May 2, 2024
@tswast
Copy link
Collaborator

tswast commented Jun 27, 2024

Once owlbot is updated, please also add py.typed file to the bigquery_magics directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-magics API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

setup mypy type checking
3 participants
@chelsea-lin @tswast @GarrettWu