Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Should not retry on INTERNAL #13

Closed
larkee opened this issue Mar 3, 2020 · 2 comments
Closed

Core: Should not retry on INTERNAL #13

larkee opened this issue Mar 3, 2020 · 2 comments
Assignees
@busunkim96
Labels
type: question Request for information or clarification. Not an issue.

Comments

@larkee
Copy link

larkee commented Mar 3, 2020

According to AIP, INTERNAL errors should not be retried.

This is a possible cause for a Spanner client issue.
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Mar 3, 2020
@busunkim96 busunkim96 added type: cleanup An internal cleanup or hygiene concern. and removed 🚨 This issue needs some love. triage me I really want to be triaged. labels Mar 9, 2020
@busunkim96 busunkim96 self-assigned this Mar 9, 2020
@busunkim96
Copy link
Contributor

busunkim96 commented Mar 9, 2020 •
edited
Loading

Hi @larkee,

The Spanner issue seems to discuss 503s specifically. Those were added to the retry status code list in googleapis/google-cloud-python#8182 in response to googleapis/google-cloud-python#5410.

503s correspond to the gRPC code UNAVAILABLE and are listed as retryable in the AIP.

500: INTERNAL
503: UNAVAILABLE

@busunkim96 busunkim96 added type: question Request for information or clarification. Not an issue. and removed type: cleanup An internal cleanup or hygiene concern. labels Mar 9, 2020
@busunkim96
Copy link
Contributor

Closing for now, but please do file a new issue or reach out via chat/email if you'd like to discuss further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@busunkim96 busunkim96

Labels
type: question Request for information or clarification. Not an issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@busunkim96 @larkee @yoshi-automation