-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support filters in matching engine vector matching #1608
Conversation
…/python-aiplatform into matching-engine-filter
Hey @jaycee-li is it necessary to have the Namespace class? I'm wondering what's the easiest way for users to understand how to go about making/using filters. |
@nayaknishant Yeah I thought about it. But the filter message is defined in gapic, I didn't find a way to make the structure simpler in SDK. If not using Namespace class, users will need to construct the filter (in dictionary or list) by themselves. I feel like this Namespace class can help users better understand the filter message. |
Sounds good. To emphasize how Namespace is used can we change the example in the comment to |
@nayaknishant Updated. |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
This PR adds the feature that was requested in b/233694218