Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for SDK Method metrics tracking via _USER_AGENT_SDK… #1591

Merged
merged 7 commits into from
Aug 17, 2022

Conversation

SinaChavoshi
Copy link
Contributor

…_COMMAND

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: vertex-ai Issues related to the googleapis/python-aiplatform API. labels Aug 12, 2022
@SinaChavoshi SinaChavoshi marked this pull request as ready for review August 15, 2022 21:50
@SinaChavoshi SinaChavoshi requested a review from a team as a code owner August 15, 2022 21:50
Copy link
Contributor

@sararob sararob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! Left a few comments. Before we submit this, is there a way to test that these method calls are getting added to a dashboard in the way we're expecting?

google/cloud/aiplatform/metadata/context.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/metadata/execution.py Show resolved Hide resolved
google/cloud/aiplatform/metadata/execution.py Show resolved Hide resolved
@SinaChavoshi SinaChavoshi merged commit 28e56ef into googleapis:main Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: vertex-ai Issues related to the googleapis/python-aiplatform API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants