Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for failure_policy in PipelineJob #1452

Merged
merged 8 commits into from
Jun 23, 2022
Merged

feat: add support for failure_policy in PipelineJob #1452

merged 8 commits into from
Jun 23, 2022

Conversation

chongyouquan
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: vertex-ai Issues related to the googleapis/python-aiplatform API. labels Jun 22, 2022
@chongyouquan chongyouquan requested a review from sararob June 22, 2022 16:27
sararob
sararob requested changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@sararob sararob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, once that's addressed this lgtm.

google/cloud/aiplatform/utils/pipeline_utils.py Outdated Show resolved Hide resolved
tests/unit/aiplatform/test_pipeline_jobs.py Show resolved Hide resolved
@chongyouquan chongyouquan requested a review from sararob June 23, 2022 16:48
@chongyouquan chongyouquan merged commit d0968ea into googleapis:main Jun 23, 2022
@release-please release-please bot mentioned this pull request Jun 23, 2022
Merged
@release-please release-please bot mentioned this pull request Jun 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sararob sararob sararob approved these changes

Assignees
No one assigned
Labels
api: vertex-ai Issues related to the googleapis/python-aiplatform API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chongyouquan @sararob