-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Improved metadata artifact and execution creation using python / SDK #1430
Merged
SinaChavoshi
merged 58 commits into
googleapis:main
from
SinaChavoshi:minimum_schema_set_from_ga
Jun 28, 2022
Merged
feat: Improved metadata artifact and execution creation using python / SDK #1430
SinaChavoshi
merged 58 commits into
googleapis:main
from
SinaChavoshi:minimum_schema_set_from_ga
Jun 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d40e612
to
49e34cc
Compare
jialuzh
approved these changes
Jun 15, 2022
sasha-gitg
requested changes
Jun 16, 2022
sasha-gitg
requested changes
Jun 22, 2022
google/cloud/aiplatform/metadata/schema/google/artifact_schema.py
Outdated
Show resolved
Hide resolved
google/cloud/aiplatform/metadata/schema/google/artifact_schema.py
Outdated
Show resolved
Hide resolved
Co-authored-by: sasha-gitg <[email protected]>
…cular import error
41a2cf6
to
bee8e93
Compare
sasha-gitg
approved these changes
Jun 28, 2022
google/cloud/aiplatform/metadata/schema/system/artifact_schema.py
Outdated
Show resolved
Hide resolved
sararob
pushed a commit
to sararob/python-aiplatform
that referenced
this pull request
Jun 29, 2022
…/ SDK (googleapis#1430) * rebase to master after ga merge * add support for artifact create * add unit tests for create from artifact parameters * update formatting * fix lint issues * Add integration tests * add support for execution types * correct execution type in create * add execution support and unit tests * add support for state in artifacts * add support for start_execution * add support for metadata_store_id in start_execution * lint and docs update based on review feedback * Add e2e integraton tests and lint update * Update google/cloud/aiplatform/metadata/artifact.py Co-authored-by: sasha-gitg <[email protected]> * remove the duplicate test_experiments_copy.py * refactor based on code review feedback * regroup tests to match module names * fix e2e integration tests * remove call to _temp_prefix = tmpvrtxsdk-e2e from E2E test * Update google/cloud/aiplatform/metadata/schema/base_execution.py Co-authored-by: sasha-gitg <[email protected]> * remove artifact and schema referencing the create result to self * remove kwargs * fix typing for container spec * remove resouceName from system types * metrics should default to None * change from using resouce_name to resource_id * fix e2e tests * change google and system to sub folders of schema * use create_from_base_execution_schema instead of overloading create * update api docs * update docstring formatting * Update google/cloud/aiplatform/metadata/metadata.py Co-authored-by: sasha-gitg <[email protected]> * add return types and move args to constructor * using forward reference for parameter and return types to resolve circular import error * change base classes to abstract classes * Add tests for system.artifact type * use resouce name instead of id and populate metadata with resourceNanme accoridngly * remove start_execution from this pr and move to a separate PR * change all args to keyword args * always make a copy of metadata instead of pass by reference * auto generate uri for google types * fix e2e tests * switch to using Artifact.create instead of _create * change typing for state to Optional * change typing for state to Optional in artifact base file * change to use the Execution.create instead of the private method * chagne copy to deepcopy for metadata Co-authored-by: sasha-gitg <[email protected]> Co-authored-by: Rosie Zou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: vertex-ai
Issues related to the googleapis/python-aiplatform API.
size: xl
Pull request size is extra large.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to add support for schema types via the python sdk.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕