Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for accepting an Artifact Registry URL in pipeline_job #1405

Merged
merged 45 commits into from
Jun 17, 2022

Conversation

chongyouquan
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Jun 1, 2022
@chongyouquan chongyouquan requested a review from sararob June 7, 2022 03:49
@sasha-gitg sasha-gitg added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 9, 2022
Copy link
Contributor

@sararob sararob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks for making those changes! Last few things before it can be merged:

  • Using urllib instead of requests
  • KFP support in AR being publicly available

If I have any additional feedback as I try out the AR integration I'll add it here.

google/cloud/aiplatform/utils/yaml_utils.py Outdated Show resolved Hide resolved
@sasha-gitg sasha-gitg removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 9, 2022
@chongyouquan chongyouquan requested a review from sararob June 10, 2022 16:21
@chongyouquan
Copy link
Contributor Author

This looks good, thanks for making those changes! Last few things before it can be merged:

  • Using urllib instead of requests
  • KFP support in AR being publicly available

If I have any additional feedback as I try out the AR integration I'll add it here.

The use of urllib instead of requests is done.
For support in AR python library for KFP packages, it'll probably only be available later (in a few months' time I think).

@chongyouquan chongyouquan requested a review from a team as a code owner June 16, 2022 16:19
@chongyouquan chongyouquan merged commit e138cfd into googleapis:main Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: vertex-ai Issues related to the googleapis/python-aiplatform API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants