-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for accepting an Artifact Registry URL in pipeline_job #1405
feat: add support for accepting an Artifact Registry URL in pipeline_job #1405
Conversation
1e6b3e0
to
ea5d41a
Compare
7cc1b78
to
d70b58f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, thanks for making those changes! Last few things before it can be merged:
- Using
urllib
instead ofrequests
- KFP support in AR being publicly available
If I have any additional feedback as I try out the AR integration I'll add it here.
This reverts commit 72cdd9e.
The use of |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕