feat: Add endpoind_id arg to Endpoint#create #1168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
mai-nakagawa
force-pushed
the
main
branch
2 times, most recently
from
b28938a to
510ce2c
Compare
sasha-gitg
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
sasha-gitg
requested changes
Apr 19, 2022
google/cloud/aiplatform/models.py
Outdated
| @@ -198,6 +198,7 @@ def network(self) -> Optional[str]: | |||
| def create( | |||
| cls, | |||
| display_name: Optional[str] = None, | |||
| endpoint_id: Optional[str] = None, | |||
There was a problem hiding this comment.
Please add this field to the end of the signature to avoid breaking changes on order of arguments(not necessary on private methods).
There was a problem hiding this comment.
Thanks for your review! Moved the field to the end(also on the private method): 14fa071
sasha-gitg
added
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
sasha-gitg
approved these changes
Apr 20, 2022
sasha-gitg
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1169 🦕