feat: Add done method for pipeline, training, and batch prediction jobs #1062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parthea
added
kokoro:force-run
yoshi-kokoro
removed
kokoro:run
sasha-gitg
reviewed
Mar 7, 2022
| network=_TEST_NETWORK, | ||
| ) | ||
|
|
||
| mock_pipeline_service_create.assert_called_once_with( |
There was a problem hiding this comment.
You can skip the assertions that are tested in the other unit test.
google/cloud/aiplatform/base.py
Outdated
|
|
||
|
|
||
| class StatefulResource(DoneMixin): | ||
| """Extends DoneMixin to check whether a job returning a stateful resource has compelted.""" |
There was a problem hiding this comment.
Suggested change
| """Extends DoneMixin to check whether a job returning a stateful resource has compelted.""" | |
| """Extends DoneMixin to check whether a job returning a stateful resource has completed.""" |
google/cloud/aiplatform/base.py
Outdated
| """Extends StatefulResource to include a check for self._gca_resource.""" | ||
|
|
||
| def done(self) -> bool: | ||
| if self._gca_resource: |
There was a problem hiding this comment.
Related to the test below that throws if run has not been invoked, which is surfaced from the state call above. An alternative is to always return False in those cases as well. This check can be updated to:
Suggested change
| if self._gca_resource: | |
| if self._gca_resource and self._gca_resource.name: |
sararob
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a done method via a
DoneMixinclass to check the status of long running jobs (returns True or False based on job state):PipelineJob,_Job, and_TrainingJobaiplatform/tests/system/aiplatform/test_e2e_tabular.pytests/unit/aiplatform/test_pipeline_jobs.pytest_jobsandtest_training_jobsFixes b/215396514