Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rename teardown fixture #1004

Merged
merged 1 commit into from
Feb 7, 2022
Merged

fix: rename teardown fixture #1004

merged 1 commit into from
Feb 7, 2022

Conversation

morgandu
Copy link
Contributor

@morgandu morgandu commented Feb 7, 2022

PyTest version 7.0 was released on Feb 4.

Calling a fixture function directly, as opposed to request them in a test function, is deprecated.

This deprecation is affecting the system tests.

@morgandu morgandu force-pushed the mor--ci-rename-teardown branch from 3ae72e2 to 5503f2b Compare February 7, 2022 18:41
@morgandu morgandu changed the title [WIP] fix: request fixture in a test function instead of calling a fixture function directly fix: request fixture in a test function instead of calling a fixture function directly Feb 7, 2022
@morgandu morgandu changed the title fix: request fixture in a test function instead of calling a fixture function directly fix: rename teardown fixture Feb 7, 2022
@morgandu morgandu merged commit fcd0096 into googleapis:main Feb 7, 2022
@release-please release-please bot mentioned this pull request Feb 7, 2022
Merged
@morgandu
Copy link
Contributor Author

morgandu commented Feb 8, 2022

Solving issues #999, #1000, #1001, #1002.

@morgandu morgandu deleted the mor--ci-rename-teardown branch February 8, 2022 00:28
abcdefgs0324 added a commit to abcdefgs0324/python-aiplatform that referenced this pull request Feb 20, 2022
@abcdefgs0324
fix: Fixed presubmit configs and pytest errors (googleapis#1004). Wil…
e9cd19d 
…l revert this after testing.
@morgandu morgandu self-assigned this Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinnysenthil vinnysenthil vinnysenthil approved these changes

@sasha-gitg sasha-gitg Awaiting requested review from sasha-gitg

Assignees

@morgandu morgandu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@morgandu @vinnysenthil