Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix enums initialization in PyPy #507

Merged
merged 5 commits into from
Jan 22, 2025
Merged

fix: fix enums initialization in PyPy #507

merged 5 commits into from
Jan 22, 2025

Conversation

airbender-1
Copy link
Contributor

@airbender-1 airbender-1 commented Nov 27, 2024 •
edited
Loading

Fix enums initialization in PyPy when removing the _pb_options name from the enum attributes.

fixes: #506

@airbender-1 airbender-1 requested a review from a team as a code owner November 27, 2024 17:56
@conventional-commit-lint-gcf Conventional Commit Lint GCF
Copy link

conventional-commit-lint-gcf bot commented Nov 27, 2024 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@airbender-1 airbender-1 changed the title fix enums initialization in PyPy when removing the _pb_options name … fix enums initialization in PyPy Nov 27, 2024
@airbender-1 airbender-1 mentioned this pull request Nov 27, 2024
Closed
@airbender-1
fix: enums initialization in PyPy
74747ee 
When removing the _pb_options name from the enum attributes,
enums initialization in PyPy should not raise exception.

Refs: googleapis#506
@parthea parthea self-assigned this Jan 22, 2025
@parthea parthea changed the title fix enums initialization in PyPy fix: fix enums initialization in PyPy Jan 22, 2025
@parthea
Copy link
Contributor

parthea commented Jan 22, 2025 •
edited
Loading

#521 should address the coverage issue The changes need to be part of this PR because tests are failing due to #506

@parthea parthea mentioned this pull request Jan 22, 2025
Closed
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 22, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 22, 2025
@parthea parthea requested a review from ohmayr January 22, 2025 11:59
parthea
parthea approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @airbender-1 !

@parthea parthea removed their assignment Jan 22, 2025
@parthea parthea mentioned this pull request Jan 22, 2025
Merged
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 22, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 22, 2025
@parthea parthea merged commit b8b68f2 into googleapis:main Jan 22, 2025
27 checks passed
This was referenced Jan 22, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parthea parthea parthea approved these changes

@ohmayr ohmayr ohmayr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enum failed to initialize in PyPy
3 participants
@airbender-1 @parthea @ohmayr