This repository has been archived by the owner on Nov 5, 2019. It is now read-only.
Pass prompt='consent' from flow_from_clientsecrets #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently there is no way to create an OAuth2WebServerFlow with a prompt argument using the flow_from_clientsecrets. Meaning developers must either call internal methods to add the prompt='consent' or read the client_secrets json themselves (so they can call the OAuth2WebServerFlow initializer themselves).
|
Seems like lint is failing on this PR. Can you address that? |
|
@jonparrott good call and done! |
|
@jonparrott travis is still failing, but I think it has to do with the tests and not my change... any advice? |
|
@tomasreimers it's just the system tests which will not pass on external PRs. |
|
Thanks, @tomasreimers. |
|
Thanks @jonparrott ! Any idea when you'll bump the version on pip? |
|
If you'll send a release PR it'll bump as soon as I merge. |
|
Done!
…On Thu, Jun 1, 2017 at 4:50 PM, Jon Wayne Parrott ***@***.***> wrote:
If you'll send a release PR
<https://github.com/google/oauth2client/pull/666/files> it'll bump as
soon as I merge.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#717 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABIkPUVhLHwJh2mfH3MjXr6OsNbHMe3Yks5r_yQzgaJpZM4NsW5t>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is no way to create an OAuth2WebServerFlow with a prompt argument using the flow_from_clientsecrets. Meaning developers must either call internal methods to add the prompt='consent' or read the client_secrets json themselves (so they can call the OAuth2WebServerFlow initializer themselves).
While this repository is technically deprecated, it is still pointed to by the official docs: https://developers.google.com/api-client-library/python/guide/aaa_oauth
Note: oauth2client is now deprecated. As such, it is unlikely that we will
review or merge to your pull request. We recommend you use
google-auth and oauthlib.