Skip to content
This repository has been archived by the owner on Nov 5, 2019. It is now read-only.

Begin transport module for httplib2 specific pieces. #559

Merged
merged 1 commit into from
Jul 21, 2016
Merged

Begin transport module for httplib2 specific pieces. #559

merged 1 commit into from
Jul 21, 2016

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Jul 20, 2016

Towards #554.

@dhermes dhermes force-pushed the begin-transport-module branch from d94fc85 to 959a672 Compare July 20, 2016 20:49
theacodes
theacodes reviewed Jul 21, 2016
View reviewed changes
oauth2client/transport.py
self.cache.pop(key, None)


def get_cached_http():

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@theacodes
Copy link
Contributor

This is a good first step but I'm interested in how you'll make this swappable.

@dhermes
Copy link
Contributor Author

dhermes commented Jul 21, 2016

@jonparrott Before making swappable, the goal is to just make the boundary explicit (see the plan in #128).

@theacodes
Copy link
Contributor

Gotcha. Okay. I'm fine with this. Nathaniel to merge.

On Wed, Jul 20, 2016, 8:00 PM Danny Hermes [email protected] wrote:

@jonparrott https://github.com/jonparrott Before making swappable, the
goal is to just make the boundary explicit (see the plan in #128
#128).

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#559 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPUc2tzwYVIbiUojAKca6xdrRrdvJjvks5qXuDTgaJpZM4JRLDv
.

@dhermes
Copy link
Contributor Author

dhermes commented Jul 21, 2016

@nathanielmanistaatgoogle PTAL

nathanielmanistaatgoogle
nathanielmanistaatgoogle reviewed Jul 21, 2016
View reviewed changes
oauth2client/transport.py
dict, the copied headers or a new dictionary if the headers
were null.
"""
if headers is None:

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@nathanielmanistaatgoogle
Copy link
Contributor

Looks mostly good.

@dhermes dhermes force-pushed the begin-transport-module branch from 959a672 to 8ae72c6 Compare July 21, 2016 17:03
@dhermes
Copy link
Contributor Author

dhermes commented Jul 21, 2016

@nathanielmanistaatgoogle Addressed the comments I could and gave an answer to the one I couldn't about non-public imports

@nathanielmanistaatgoogle
Copy link
Contributor

Looks great; merge (with squashed commits) when tests repass.

@dhermes dhermes force-pushed the begin-transport-module branch from 8ae72c6 to 213050d Compare July 21, 2016 17:12
@dhermes
Copy link
Contributor Author

dhermes commented Jul 21, 2016

See #558 about coverage failing. Not my sword to fall on here. Merging.

@dhermes dhermes merged commit 11482ad into googleapis:master Jul 21, 2016
@dhermes dhermes deleted the begin-transport-module branch July 21, 2016 17:23
@theacodes theacodes mentioned this pull request Jul 28, 2016
Merged
@dhermes dhermes mentioned this pull request Aug 1, 2016
Closed
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dhermes @theacodes @nathanielmanistaatgoogle @googlebot