This repository has been archived by the owner on Nov 5, 2019. It is now read-only.
Stop sending scopes in token requests on GCE #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhermes
force-pushed
the
fix-gce-acquire-2
branch
from
d4034d3 to
9c5b132
Compare
| @@ -51,13 +59,17 @@ class AppAssertionCredentials(AssertionCredentials): | |||
| """ | |||
|
|
|||
| @util.positional(2) | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
dhermes
force-pushed
the
fix-gce-acquire-2
branch
from
9c5b132 to
01c894e
Compare
| @@ -107,7 +117,7 @@ def serialization_data(self): | |||
| 'Cannot serialize credentials for GCE service accounts.') | |||
|
|
|||
| def create_scoped_required(self): | |||
| return not self.scope | |||
| return False | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Also check to warn a user when a scope is passed (since scopes have no effect for GCE service accounts).
dhermes
force-pushed
the
fix-gce-acquire-2
branch
from
01c894e to
6319e76
Compare
| if scope: | ||
| warnings.warn(_SCOPES_WARNING) | ||
| # This is just provided for backwards compatibility, but is not | ||
| # used by this class. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@nathanielmanistaatgoogle What remains to be done here? |
|
To my knowledge nothing remains to be done here. Merge? |
|
Good deal. |
dhermes
added a commit
that referenced
this pull request
Feb 20, 2016
Stop sending scopes in token requests on GCE
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Has #411 as diffbase.