Fixing broken token acquire endpoint on GCE. #411
Conversation
dhermes
force-pushed
the
fix-gce-acquire
branch
from
5e03870 to
212c485
Compare
| @@ -58,6 +58,9 @@ def __init__(self, scope, **kwargs): | |||
| scope: string or iterable of strings, scope(s) of the credentials | |||
| being requested. | |||
| """ | |||
| # if scope: | |||
| # raise ValueError('GCE will not respect your scopes so what ' | |||
| # 'is the point?') | |||
| self.scope = util.scopes_to_string(scope) | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@nathanielmanistaatgoogle PTAL. This is a serious regression and we should deal with it quickly. |
| @@ -58,6 +58,9 @@ def __init__(self, scope, **kwargs): | |||
| scope: string or iterable of strings, scope(s) of the credentials | |||
| being requested. | |||
| """ | |||
| # if scope: | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Thank you for emphasizing the importance of this; I'm happy to be around to respond to it for the next several hours. |
|
Please squash commits. |
|
Will squash commits post review. Any issues other than the fake 4th commit? |
dhermes
force-pushed
the
fix-gce-acquire
branch
from
2c19b95 to
23b998a
Compare
| @@ -51,13 +59,17 @@ class AppAssertionCredentials(AssertionCredentials): | |||
| """ | |||
|
|
|||
| @util.positional(2) | |||
| def __init__(self, scope, **kwargs): | |||
| def __init__(self, scope='', **kwargs): | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
The commit log message of 23b998a is weird for the way it contains a verb tense problem ("in the process also [...] warning a user") and the hash, author, and date of an earlier draft commit. |
dhermes
force-pushed
the
fix-gce-acquire
branch
from
23b998a to
e2fceed
Compare
|
@nathanielmanistaatgoogle Fixed the commit message |
|
@nathanielmanistaatgoogle I'm going to break this in two. Will ping you once updated. |
dhermes
force-pushed
the
fix-gce-acquire
branch
from
e2fceed to
a2857cb
Compare
|
@nathanielmanistaatgoogle PTAL. Sent out #419 for the contentious pieces. |
|
Looks good; merge when you like. |
|
@nathanielmanistaatgoogle Do you want to cut a |
Fixing broken token acquire endpoint on GCE.
|
Please cut a |
|
Sorry, just double checked PEP 440 and I think the correct version would be |
|
Confirmed, it should be |
I wanted to get this out there before writing / running tests, so there may be a follow on commit.
See #387 and googleapis/google-cloud-python#1484 for context.
/cc @nathanielmanistaatgoogle @jonparrott @jgeewax @tseaver @Galabar001