Skip to content
This repository has been archived by the owner on Nov 5, 2019. It is now read-only.

return_url might be None #640

Closed
letsmakesense opened this issue Sep 3, 2016 · 3 comments
Closed

return_url might be None #640

letsmakesense opened this issue Sep 3, 2016 · 3 comments
Labels
Milestone

Comments

@letsmakesense
Copy link

Hi,

in .contrib.django_util.views.py on line 182 the variable 'return_url' is None if no GET value is given for 'return_url, which will cause a type error.

A default for return_url is provided later in line 187. Would it be possible to move this default to line 172?

return_url = request.GET.get('return_url', request.META.get('HTTP_REFERER', '/'))

Regards,
Peter

@theacodes
Copy link
Contributor

@waprin will take a look at this once he gets back from vacation. :)

@theacodes theacodes modified the milestone: 4.0.0 Sep 13, 2016
@pferate
Copy link
Contributor

pferate commented Oct 14, 2016

@jonparrott: Looks like this was resolved in #651

@theacodes
Copy link
Contributor

Great. :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants