Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add property frequencyPenalty in type defintions #394

Merged
merged 3 commits into from
Aug 21, 2024

Conversation

bearjaws
Copy link
Contributor

@bearjaws bearjaws commented Aug 5, 2024

Hey all, was working with gemini-flash-1.5 and noticed that frequencyPenalty was not documented in typescript. Taken from these docs: https://cloud.google.com/vertex-ai/generative-ai/docs/model-reference/inference

I validated that it gets parsed into formulateRequest in generative_models.js when calling generateContent.

One item I was not sure about was how much input validate we want to add?

I see we are validating topK in validateGenerationConfig but that is the only thing, all other properties are missing and will error out on the API side.

Let me know if you want me to add checks there or change anything else. I have signed the Contributor License Agreement

Thank you!

@product-auto-label product-auto-label bot added the api: aiplatform Issues related to the googleapis/nodejs-vertexai API. label Aug 5, 2024
@happy-qiao happy-qiao added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 21, 2024
@happy-qiao happy-qiao changed the title fix: missing property frequencyPenalty in type defintions chore: missing property frequencyPenalty in type defintions Aug 21, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 21, 2024
@yyyu-google yyyu-google added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 21, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 21, 2024
@happy-qiao happy-qiao merged commit 7557a83 into googleapis:main Aug 21, 2024
8 of 9 checks passed
@happy-qiao happy-qiao changed the title chore: missing property frequencyPenalty in type defintions chore: add property frequencyPenalty in type defintions Aug 21, 2024
@happy-qiao happy-qiao added the pr:community PR from open source community label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: aiplatform Issues related to the googleapis/nodejs-vertexai API. pr:community PR from open source community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants