Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update isPublic() to include allAuthenticatedUsers #808

Closed
frankyn opened this issue Aug 13, 2019 · 1 comment
Closed

Update isPublic() to include allAuthenticatedUsers #808

frankyn opened this issue Aug 13, 2019 · 1 comment
Assignees
@frankyn
Labels
api: storage Issues related to the googleapis/nodejs-storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@frankyn
Copy link
Member

frankyn commented Aug 13, 2019

Introduced in #708. The method helps developers understand if a given object is publicly accessible.

One case that was not covered in the PR was authenticated access to public objects. IAM has the identifier allAuthenticatedUsers with the following capability(doc):

This is a special identifier that represents anyone who is authenticated with a Google account or a service account. Users who are not authenticated, such as anonymous visitors, are not included.

isPublic() should make a HEAD request using client credentials as well. This effectively requires two separate requests.
@frankyn frankyn added the type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. label Aug 13, 2019
@JustinBeckwith JustinBeckwith added the priority: p2 Moderately-important priority. Fix may not be included in next release. label Aug 14, 2019
@frankyn
Copy link
Member Author

frankyn commented Sep 10, 2019

Speaking with @jkwlui, this is more of a FR than a bug.
The request was to include allAuthenticatedUsers as well, but the semantic meaning behind this API is to support public data access checks.

I'm closing for now as it requires a design document due to the complex subtleties.

@frankyn frankyn closed this as completed Sep 10, 2019
@google-cloud-label-sync google-cloud-label-sync bot added the api: storage Issues related to the googleapis/nodejs-storage API. label Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frankyn frankyn

Labels
api: storage Issues related to the googleapis/nodejs-storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JustinBeckwith @frankyn