Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undocumented breaking change in v7 #2285

Closed
runeh opened this issue Aug 25, 2023 · 5 comments · Fixed by #2286
Closed

Undocumented breaking change in v7 #2285

runeh opened this issue Aug 25, 2023 · 5 comments · Fixed by #2286
Assignees
@ddelgrosso1
Labels
api: storage Issues related to the googleapis/nodejs-storage API. type: docs Improvement to the documentation for an API.

Comments

@runeh
Copy link

runeh commented Aug 25, 2023

Typings was added for file metadata in #2234 which was seemingly was released with 7.0.0.

This is a breaking change, code no longer compiles if the assumptions about the previously typed any are different from the ones in the new FileMetaData.

Really appreciate getting proper typings for these objects! But would be great with a heads up. Might we worth updating the release notes.
@runeh runeh added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Aug 25, 2023
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/nodejs-storage API. label Aug 25, 2023
@tritone tritone added type: docs Improvement to the documentation for an API. and removed type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Aug 28, 2023
@tritone
Copy link
Contributor

tritone commented Aug 28, 2023

Thanks for the issue; you're correct and we can update the release notes as you suggest.

@ddelgrosso1
Copy link
Contributor

Looks like there was a problem with some merges and the release notes not updating automatically / correctly. I will see about getting them corrected.

@ddelgrosso1 ddelgrosso1 mentioned this issue Aug 29, 2023
Merged
4 tasks
@duncannz
Copy link

duncannz commented Mar 7, 2024

The additional breaking changes are still missing from the Github release notes. Is it possible to also fix these?

@ddelgrosso1
Copy link
Contributor

@duncannz let me see about regenerating the Github side of things.

@ddelgrosso1
Copy link
Contributor

Updated the Github release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ddelgrosso1 ddelgrosso1

Labels
api: storage Issues related to the googleapis/nodejs-storage API. type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: manually fix release notes for 7.0 ddelgrosso1/nodejs-storage
4 participants
@runeh @tritone @duncannz @ddelgrosso1