Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: deprecate bucket.setLabels #2141

Closed
ddelgrosso1 opened this issue Feb 3, 2023 · 0 comments
Closed

refactor: deprecate bucket.setLabels #2141

ddelgrosso1 opened this issue Feb 3, 2023 · 0 comments
Assignees
@ddelgrosso1
Labels
api: storage Issues related to the googleapis/nodejs-storage API. next major: breaking change this is a change that we should wait to bundle into the next major version priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@ddelgrosso1
Copy link
Contributor

bucket.setLabels is nothing more than a wrapper around bucket.setMetadata. There was a recent customer issue where the customer was chaining calls to setLabels and setMetadata when in fact this could be accomplished in a single call. We should deprecate setLabels and instead document how to achieve the same functionality utilizing setMetadata.
@ddelgrosso1 ddelgrosso1 added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. next major: breaking change this is a change that we should wait to bundle into the next major version labels Feb 3, 2023
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/nodejs-storage API. label Feb 3, 2023
@ddelgrosso1 ddelgrosso1 added type: cleanup An internal cleanup or hygiene concern. and removed type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Feb 7, 2023
@ddelgrosso1 ddelgrosso1 mentioned this issue Jun 7, 2023
Merged
4 tasks
@ddelgrosso1 ddelgrosso1 self-assigned this Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ddelgrosso1 ddelgrosso1

Labels
api: storage Issues related to the googleapis/nodejs-storage API. next major: breaking change this is a change that we should wait to bundle into the next major version priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ddelgrosso1