From 53ee487b46fd78da88276429bd9c6f4bb5ae2045 Mon Sep 17 00:00:00 2001 From: dpebot Date: Fri, 21 Sep 2018 14:41:38 -0700 Subject: [PATCH] Re-generate library using /synth.py --- .circleci/npm-install-retry.js | 2 +- .kokoro/presubmit/node8/samples-test.cfg | 7 +++++++ .kokoro/presubmit/node8/system-test.cfg | 7 +++++++ smoke-test/language_service_smoke_test.js | 3 +-- src/v1/language_service_client.js | 2 +- src/v1beta2/language_service_client.js | 2 +- 6 files changed, 18 insertions(+), 5 deletions(-) create mode 100644 .kokoro/presubmit/node8/samples-test.cfg create mode 100644 .kokoro/presubmit/node8/system-test.cfg diff --git a/.circleci/npm-install-retry.js b/.circleci/npm-install-retry.js index ae3220d7..3240aa2c 100755 --- a/.circleci/npm-install-retry.js +++ b/.circleci/npm-install-retry.js @@ -6,7 +6,7 @@ let spawn = require('child_process').spawn; //USE: ./index.js [... NPM ARGS] // -let timeout = process.argv[2] || 60000; +let timeout = process.argv[2] || process.env.NPM_INSTALL_TIMEOUT || 60000; let attempts = process.argv[3] || 3; let args = process.argv.slice(4); if (args.length === 0) { diff --git a/.kokoro/presubmit/node8/samples-test.cfg b/.kokoro/presubmit/node8/samples-test.cfg new file mode 100644 index 00000000..b171e141 --- /dev/null +++ b/.kokoro/presubmit/node8/samples-test.cfg @@ -0,0 +1,7 @@ +# Download resources for system tests (service account key, etc.) +gfile_resources: "/bigstore/cloud-devrel-kokoro-resources/google-cloud-nodejs" + +env_vars: { + key: "TRAMPOLINE_BUILD_FILE" + value: "github/nodejs-language/.kokoro/samples-test.sh" +} diff --git a/.kokoro/presubmit/node8/system-test.cfg b/.kokoro/presubmit/node8/system-test.cfg new file mode 100644 index 00000000..b53d278a --- /dev/null +++ b/.kokoro/presubmit/node8/system-test.cfg @@ -0,0 +1,7 @@ +# Download resources for system tests (service account key, etc.) +gfile_resources: "/bigstore/cloud-devrel-kokoro-resources/google-cloud-nodejs" + +env_vars: { + key: "TRAMPOLINE_BUILD_FILE" + value: "github/nodejs-language/.kokoro/system-test.sh" +} diff --git a/smoke-test/language_service_smoke_test.js b/smoke-test/language_service_smoke_test.js index 2a3d5f7e..8acc7ed1 100644 --- a/smoke-test/language_service_smoke_test.js +++ b/smoke-test/language_service_smoke_test.js @@ -28,8 +28,7 @@ describe('LanguageServiceSmokeTest', () => { content: content, type: type, }; - client - .analyzeSentiment({document: document}) + client.analyzeSentiment({document: document}) .then(responses => { const response = responses[0]; console.log(response); diff --git a/src/v1/language_service_client.js b/src/v1/language_service_client.js index bb988b69..74309f84 100644 --- a/src/v1/language_service_client.js +++ b/src/v1/language_service_client.js @@ -127,7 +127,7 @@ class LanguageServiceClient { 'classifyText', 'annotateText', ]; - for (const methodName of languageServiceStubMethods) { + for (let methodName of languageServiceStubMethods) { this._innerApiCalls[methodName] = gax.createApiCall( languageServiceStub.then( stub => diff --git a/src/v1beta2/language_service_client.js b/src/v1beta2/language_service_client.js index 8f15b038..75007fe8 100644 --- a/src/v1beta2/language_service_client.js +++ b/src/v1beta2/language_service_client.js @@ -127,7 +127,7 @@ class LanguageServiceClient { 'classifyText', 'annotateText', ]; - for (const methodName of languageServiceStubMethods) { + for (let methodName of languageServiceStubMethods) { this._innerApiCalls[methodName] = gax.createApiCall( languageServiceStub.then( stub =>