Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: Update WithFieldData and PartialWithFieldData to ignore methods on types #2294

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix!: Update WithFieldData and PartialWithFieldData to ignore methods on types #2294

wants to merge 5 commits into from
+147 −35

Conversation

MarkDuckworth
Copy link
Contributor

@MarkDuckworth MarkDuckworth commented Feb 14, 2025 •
edited
Loading

Partially fixes #2291 - Will not affect methods on types passed to WithFieldData and PartialWithFieldData.

This has some potential to be a breaking change, so I have marked it as such. To be safe, I will include it in the next major version release.

@MarkDuckworth MarkDuckworth requested review from a team as code owners February 14, 2025 23:10
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: firestore Issues related to the googleapis/nodejs-firestore API. labels Feb 14, 2025
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Feb 18, 2025
@MarkDuckworth MarkDuckworth changed the title Update WithFieldData and PartialWithFieldData to ignore methods on types fix!: Update WithFieldData and PartialWithFieldData to ignore methods on types Feb 18, 2025
@MarkDuckworth MarkDuckworth added next major: breaking change this is a change that we should wait to bundle into the next major version do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Feb 18, 2025
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milaGGL milaGGL Awaiting requested review from milaGGL

At least 1 approving review is required to merge this pull request.

Assignees

@milaGGL milaGGL

Labels
api: firestore Issues related to the googleapis/nodejs-firestore API. do not merge Indicates a pull request not ready for merge, due to either quality or timing. next major: breaking change this is a change that we should wait to bundle into the next major version size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WithFieldValue mangles Class Types
2 participants
@MarkDuckworth @milaGGL