Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Return computed distance and set distance thresholds on VectorQueries #2090

Merged
merged 18 commits into from
Sep 5, 2024
Merged

feat: Return computed distance and set distance thresholds on VectorQueries #2090

merged 18 commits into from
Sep 5, 2024

Conversation

MarkDuckworth
Copy link
Contributor

@MarkDuckworth MarkDuckworth commented Jul 26, 2024 •
edited
Loading

Return computed distance and set distance thresholds on VectorQueries

@MarkDuckworth MarkDuckworth added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 26, 2024
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: firestore Issues related to the googleapis/nodejs-firestore API. labels Jul 26, 2024
@MarkDuckworth MarkDuckworth requested a review from wu-hui July 31, 2024 17:53
@MarkDuckworth MarkDuckworth changed the title WIP: distance Distance Jul 31, 2024
@MarkDuckworth
Copy link
Contributor Author

Needs DTS updates

@MarkDuckworth MarkDuckworth added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 6, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 6, 2024
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: xl Pull request size is extra large. labels Aug 12, 2024
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Aug 14, 2024
@MarkDuckworth MarkDuckworth changed the title Distance feat: Return computed distance and set distance thresholds on VectorQueries Aug 14, 2024
@MarkDuckworth MarkDuckworth requested a review from wu-hui August 14, 2024 21:41
wu-hui
wu-hui approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@wu-hui wu-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. you have some it.only to remove I think.

@MarkDuckworth MarkDuckworth added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Aug 27, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 27, 2024
@MarkDuckworth MarkDuckworth added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 27, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 27, 2024
@MarkDuckworth MarkDuckworth added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Aug 27, 2024
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 27, 2024
@MarkDuckworth MarkDuckworth added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 4, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 4, 2024
@MarkDuckworth MarkDuckworth added do not merge Indicates a pull request not ready for merge, due to either quality or timing. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 4, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 4, 2024
@MarkDuckworth MarkDuckworth added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 5, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 5, 2024
@MarkDuckworth MarkDuckworth removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 5, 2024
@MarkDuckworth MarkDuckworth requested a review from wu-hui September 5, 2024 17:51
wu-hui
wu-hui approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@wu-hui wu-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go!

@MarkDuckworth MarkDuckworth merged commit b5ca84f into main Sep 5, 2024
19 checks passed
@MarkDuckworth MarkDuckworth deleted the markduckworth/vector-distance branch September 5, 2024 18:58
@release-please release-please bot mentioned this pull request Sep 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wu-hui wu-hui wu-hui approved these changes

Assignees

@wu-hui wu-hui

Labels
api: firestore Issues related to the googleapis/nodejs-firestore API. size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MarkDuckworth @wu-hui @kokoro-team @yoshi-kokoro