Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make not uploading to docuploader the default #76

Open
dansaadati opened this issue Apr 4, 2023 · 0 comments
Open

feat: make not uploading to docuploader the default #76

dansaadati opened this issue Apr 4, 2023 · 0 comments
Assignees
@dansaadati
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@dansaadati
Copy link
Contributor

In order to prevent breaking changes on nodejs-cloud-rad callers, we have inversed the condition where not uploading was the default behavior: #71. We should change this so uploading is the default, and callers should specific they want to upload by setting a environment variable UPLOAD=1. This should be done along with a major version change so that downstream clients are broken.
@dansaadati dansaadati added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Apr 4, 2023
@dansaadati dansaadati mentioned this issue Apr 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dansaadati dansaadati

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dansaadati