Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider migrating from pumpify to pipeline or to Readable.from #1477

Open
leahecole opened this issue Sep 24, 2024 · 0 comments
Open

Consider migrating from pumpify to pipeline or to Readable.from #1477

leahecole opened this issue Sep 24, 2024 · 0 comments
Labels
next major: breaking change this is a change that we should wait to bundle into the next major version priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@leahecole
Copy link
Contributor

The pumpify library for streams can be a bit flaky. Recommending that when someone has time, to consider using pipeline or Readable.from instead.

Readable.from example:

async function* concatStreams(streams: ReadableStream[]) {
  for (const stream of streams) {
    yield* stream;
  }
}

const readable = Readable.from(concatStreams());

(Original comment from a thread in a gax PR googleapis/gax-nodejs#1653 (comment))

@leahecole leahecole added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Sep 24, 2024
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/nodejs-bigtable API. label Sep 24, 2024
@leahecole leahecole added next major: breaking change this is a change that we should wait to bundle into the next major version and removed api: bigtable Issues related to the googleapis/nodejs-bigtable API. labels Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next major: breaking change this is a change that we should wait to bundle into the next major version priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

1 participant