Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: clean cached rows and responses after conversion #1393

Merged
merged 5 commits into from
Jul 31, 2024

Conversation

alvarowolfx
Copy link
Contributor

Reduce memory footprint when fetching data.

Tests running query: 'SELECT repository_url as url, repository_owner as owner, repository_forks as forks FROM bigquery-public-data.samples.github_timeline where repository_url is not null LIMIT 1000000'

Before change: ~70mb of heap memory usage
After change: ~35mb of heap memory usage

Towards #1392

@alvarowolfx alvarowolfx requested review from a team as code owners July 11, 2024 14:56
@alvarowolfx alvarowolfx requested a review from shollyman July 11, 2024 14:56
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/nodejs-bigquery API. labels Jul 11, 2024
@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 11, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 11, 2024
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heaps of goodness!

@shollyman shollyman added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 29, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 29, 2024
@alvarowolfx alvarowolfx merged commit 3fd28b8 into googleapis:main Jul 31, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/nodejs-bigquery API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants