Skip to content
This repository has been archived by the owner on Jul 20, 2023. It is now read-only.

fix: removing migrated samples (to nodejs-docs-samples) from repo #555

Merged
merged 12 commits into from
Dec 6, 2022
Merged

fix: removing migrated samples (to nodejs-docs-samples) from repo #555

merged 12 commits into from
Dec 6, 2022

Conversation

pattishin
Copy link
Contributor

@pattishin pattishin commented Nov 23, 2022 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Issue: Removing migrated samples
Original migration PR: GoogleCloudPlatform/nodejs-docs-samples#2876

@pattishin pattishin requested review from a team as code owners November 23, 2022 23:16
@snippet-bot
Copy link

snippet-bot bot commented Nov 23, 2022 •
edited
Loading

Here is the summary of changes.

You are about to delete 504 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: vertex-ai Issues related to the googleapis/nodejs-ai-platform API. labels Nov 23, 2022
@generated-files-bot
Copy link

generated-files-bot bot commented Nov 23, 2022 •
edited
Loading

Warning: This pull request is touching the following templated files:

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Nov 23, 2022
@pattishin pattishin added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 23, 2022
@pattishin pattishin requested a review from telpirion November 23, 2022 23:20
@pattishin pattishin removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 29, 2022
@pattishin
Copy link
Contributor Author

pattishin commented Dec 1, 2022 •
edited
Loading

Resolving last snippet refs. Holding off merge till last CL refactor gets merged in.

@pattishin
Copy link
Contributor Author

Resolving last snippet refs. Holding off merge till last CL refactor gets merged in.

All remaining samples have paths updated. Ready for review! 👀

@pattishin pattishin merged commit 0864901 into main Dec 6, 2022
@pattishin pattishin deleted the refactor/fixit-migration-remove-samples branch December 6, 2022 19:53
@release-please release-please bot mentioned this pull request Dec 6, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@telpirion telpirion telpirion approved these changes

@nicain nicain nicain approved these changes

Assignees
No one assigned
Labels
api: vertex-ai Issues related to the googleapis/nodejs-ai-platform API. samples Issues that are directly related to samples. size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pattishin @nicain @telpirion