Skip to content
This repository has been archived by the owner on Jul 20, 2023. It is now read-only.

feat(samples): add entity type apis samples #339

Merged
merged 13 commits into from
Aug 3, 2022
Merged

feat(samples): add entity type apis samples #339

merged 13 commits into from
Aug 3, 2022

Conversation

suryaguthikonda
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #313

@suryaguthikonda suryaguthikonda requested review from a team as code owners June 24, 2022 14:53
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: vertex-ai Issues related to the googleapis/nodejs-ai-platform API. samples Issues that are directly related to samples. labels Jun 24, 2022
@snippet-bot
Copy link

snippet-bot bot commented Jun 24, 2022 •
edited
Loading

Here is the summary of changes.

You are about to add 9 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@diemtvu diemtvu requested a review from dizcology June 27, 2022 12:35
@diemtvu diemtvu added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 27, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 27, 2022
@diemtvu diemtvu added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 27, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 27, 2022
diemtvu
diemtvu reviewed Jun 28, 2022
View reviewed changes
samples/get-entity-type-sample.js Outdated
entityTypeId,
location = 'us-central1',
apiEndpoint = 'us-central1-aiplatform.googleapis.com',
timeout = 300000
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change to 5s for Get/List methods

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made the respective changes

samples/list-entity-types-async-sample.js Outdated
featurestoreId,
location = 'us-central1',
apiEndpoint = 'us-central1-aiplatform.googleapis.com',
timeout = 300000
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5s

samples/list-entity-types-sample.js Outdated
featurestoreId,
location = 'us-central1',
apiEndpoint = 'us-central1-aiplatform.googleapis.com',
timeout = 300000
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5s

samples/list-entity-types-stream-sample.js Outdated
featurestoreId,
location = 'us-central1',
apiEndpoint = 'us-central1-aiplatform.googleapis.com',
timeout = 300000
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5s

dizcology
dizcology previously approved these changes Jul 11, 2022
View reviewed changes
@junkourata junkourata added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 26, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 26, 2022
@junkourata junkourata added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 28, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 28, 2022
@junkourata junkourata added the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Jul 28, 2022
@gcf-merge-on-green gcf-merge-on-green bot dismissed dizcology’s stale review July 28, 2022 21:58

This review does not reference the most recent commit, and you are using the secure version of merge-on-green. Please re-review the most recent commit.

@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Jul 29, 2022
@junkourata junkourata added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit labels Jul 29, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 29, 2022
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Jul 29, 2022
@junkourata junkourata added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 3, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 3, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 3, 2022
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Aug 3, 2022
@junkourata junkourata added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 3, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 3, 2022
@junkourata junkourata merged commit 5bb18f3 into googleapis:main Aug 3, 2022
@release-please release-please bot mentioned this pull request Aug 3, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@diemtvu diemtvu diemtvu approved these changes

@dizcology dizcology dizcology approved these changes

Assignees
No one assigned
Labels
api: vertex-ai Issues related to the googleapis/nodejs-ai-platform API. samples Issues that are directly related to samples. size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add sample snippets for Vertex Feature Store
5 participants
@suryaguthikonda @dizcology @diemtvu @yoshi-kokoro @junkourata