fix!: update token endpoints to non-deprecated endpoints #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Both of the endpoints changed in this PR are marked as I also cleaned up some unused variables in tests that were giving linter warnings. |
ddelgrosso1
added
the
do not merge
|
Marking |
ddelgrosso1
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
danielbankhead
approved these changes
Aug 23, 2023
src/index.ts
Outdated
| const GOOGLE_REVOKE_TOKEN_URL = | ||
| 'https://accounts.google.com/o/oauth2/revoke?token='; | ||
| 'https://oauth2.googleapis.com/token/revoke?token='; |
There was a problem hiding this comment.
where did you get this revoke url from?
There was a problem hiding this comment.
In the documentation it said that the revoke old url (accounts.google.com) was extremely deprecated, so I browsed through the proto from the yaqs issue and saw revoke was in there.
There was a problem hiding this comment.
Got it. As long as it works, it should be ok.
ddelgrosso1
force-pushed
the
update-endpoints
branch
from
29ae929 to
63799b9
Compare
ddelgrosso1
commented
Oct 20, 2023
src/index.ts
Outdated
| const GOOGLE_TOKEN_URL = 'https://www.googleapis.com/oauth2/v4/token'; | ||
| const GOOGLE_REVOKE_TOKEN_URL = | ||
| 'https://accounts.google.com/o/oauth2/revoke?token='; | ||
| const GOOGLE_TOKEN_URL = 'https://oauth2.googleapis.com/token'; |
There was a problem hiding this comment.
ddelgrosso1
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
ddelgrosso1
removed
the
do not merge
ddelgrosso1
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
ddelgrosso1
commented
Oct 24, 2023
src/index.ts
Outdated
| const GOOGLE_REVOKE_TOKEN_URL = | ||
| 'https://accounts.google.com/o/oauth2/revoke?token='; | ||
| const GOOGLE_TOKEN_URL = 'https://oauth2.googleapis.com/token'; | ||
| const GOOGLE_REVOKE_TOKEN_URL = 'https://oauth2.googleapis.com/revoke?token='; |
There was a problem hiding this comment.
danielbankhead
approved these changes
Nov 29, 2023
d-goog
changed the title
d-goog
approved these changes
Feb 6, 2025
product-auto-label
bot
added
size: m
One of the layers of this build system throws with 'reserved' keyword, while typescript itself doesn't
product-auto-label
bot
added
size: s
sofisl
approved these changes
Feb 6, 2025
|
Merged and will further test this in auth downstream via the release candidate of this library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #388 🦕