-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): Update the Java code generator (gapic-generator-java) to 2.31.0 #2349
Conversation
Hi @suztomo, PR is missing grpc artifact IIUC comparing it against storage-v2; |
I thought we didn't need it so I didn't add grpc- part in https://github.com/googleapis/java-storage/pull/2347/files. Do you need it? |
"ci / dependencies (17)" failed https://github.com/googleapis/java-storage/actions/runs/7429540884/job/20218238157?pr=2349.
This is just a matter of removing the unused dependency from the pom.xml. |
@@ -197,6 +202,7 @@ | |||
<module>google-cloud-storage</module> | |||
<module>grpc-google-cloud-storage-v2</module> | |||
<module>proto-google-cloud-storage-v2</module> | |||
<module>proto-google-cloud-storage-control-v2</module> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sydney-munro google-cloud-storage-control module is missing. Would you add it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sydney-munro google-cloud-storage-control is missing pom.xml. Can you create one by copying contents from https://github.com/googleapis/java-storage/blob/main/gapic-google-cloud-storage-v2/pom.xml (You need to edit artifact IDs and might need to adjust dependencies) If that's a trouble for you, I can help.
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> | ||
<modelVersion>4.0.0</modelVersion> | ||
<groupId>com.google.cloud</groupId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Group ID is good.
PiperOrigin-RevId: 596645164
Source-Link: googleapis/googleapis@4a0e62e
Source-Link: https://github.com/googleapis/googleapis-gen/commit/a10ed6a77676c37e60799098d48d0afb16008613
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYTEwZWQ2YTc3Njc2YzM3ZTYwNzk5MDk4ZDQ4ZDBhZmIxNjAwODYxMyJ9
feat: add Storage Control API
PiperOrigin-RevId: 596130676
Source-Link: googleapis/googleapis@ce07d24
Source-Link: https://github.com/googleapis/googleapis-gen/commit/7de5bf064581832c3fff93ab51b4c0b1d0d14aa1
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiN2RlNWJmMDY0NTgxODMyYzNmZmY5M2FiNTFiNGMwYjFkMGQxNGFhMSJ9