feat: implement BufferToDiskThenUpload BlobWriteSessionConfig #2139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
BenWhitehead
force-pushed
the
write-acceleration/m1/2/throughput-sink
branch
from
c0e9cd3 to
d277957
Compare
BenWhitehead
force-pushed
the
write-acceleration/m1/3/buffer-to-disk-then-upload
branch
3 times, most recently
from
eb5d77a to
f57b294
Compare
BenWhitehead
force-pushed
the
write-acceleration/m1/2/throughput-sink
branch
from
d277957 to
b0c9cc1
Compare
BenWhitehead
force-pushed
the
write-acceleration/m1/3/buffer-to-disk-then-upload
branch
from
f57b294 to
203ee70
Compare
google-cloud-storage/src/main/java/com/google/cloud/storage/RecoveryFile.java
Show resolved
Hide resolved
google-cloud-storage/src/main/java/com/google/cloud/storage/RecoveryFile.java
Show resolved
Hide resolved
sydney-munro
approved these changes
Jul 31, 2023
BenWhitehead
force-pushed
the
write-acceleration/m1/3/buffer-to-disk-then-upload
branch
from
2c436a5 to
203ee70
Compare
There are scenarios in which disk space is more plentiful than memory space. This new BlobWriteSessionConfig allows augmenting an instance of storage to prefer buffering to disk rather than keeping things in memory. Once the file on disk is closed, the entire file will then be uploaded to GCS.
BenWhitehead
force-pushed
the
write-acceleration/m1/3/buffer-to-disk-then-upload
branch
from
203ee70 to
24ccb78
Compare
BenWhitehead
deleted the
write-acceleration/m1/3/buffer-to-disk-then-upload
branch
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are scenarios in which disk space is more plentiful than memory space. This new BlobWriteSessionConfig allows augmenting an instance of storage to prefer buffering to disk rather than keeping things in memory.
Once the file on disk is closed, the entire file will then be uploaded to GCS.