Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(samples): add storage_grpc_quickstart samples #2041

Merged
merged 6 commits into from
Jun 22, 2023
Merged

docs(samples): add storage_grpc_quickstart samples #2041

merged 6 commits into from
Jun 22, 2023

Conversation

BenWhitehead
Copy link
Collaborator

No description provided.

@snippet-bot
Copy link

snippet-bot bot commented May 31, 2023 •
edited
Loading

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the googleapis/java-storage API. samples Issues that are directly related to samples. labels May 31, 2023
@BenWhitehead BenWhitehead force-pushed the samples/grpc branch 2 times, most recently from 635d4bc to fc79b30 Compare May 31, 2023 15:50
@gcf-owl-bot gcf-owl-bot bot requested review from a team as code owners May 31, 2023 15:53
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels May 31, 2023
@BenWhitehead BenWhitehead added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 31, 2023
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels May 31, 2023
frankyn
frankyn reviewed Jun 22, 2023
View reviewed changes
Copy link
Member

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one last comment from my side

samples/snippets/src/main/java/com/example/storage/QuickstartGrpcDpSample.java Show resolved Hide resolved
tritone
tritone approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some comment things, otherwise LGTM

samples/snippets/src/main/java/com/example/storage/QuickstartGrpcDpSample.java Show resolved Hide resolved
samples/snippets/src/main/java/com/example/storage/QuickstartGrpcDpSample.java Outdated Show resolved Hide resolved
@BenWhitehead BenWhitehead changed the title docs(samples): add storage_quickstart_grpc sample docs(samples): add storage_grpc_quickstart samples Jun 22, 2023
@BenWhitehead BenWhitehead added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 22, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 22, 2023
@BenWhitehead BenWhitehead added the automerge Merge the pull request once unit tests and other checks pass. label Jun 22, 2023
@BenWhitehead BenWhitehead merged commit 5f916fb into main Jun 22, 2023
@BenWhitehead BenWhitehead deleted the samples/grpc branch June 22, 2023 22:17
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 22, 2023
@release-please release-please bot mentioned this pull request Jun 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankyn frankyn frankyn left review comments

@tritone tritone tritone approved these changes

Assignees

@anguillanneuf anguillanneuf

Labels
api: storage Issues related to the googleapis/java-storage API. samples Issues that are directly related to samples. size: m Pull request size is medium.
Projects
None yet
Milestone
Storage gRPC implementation
Development

Successfully merging this pull request may close these issues.
5 participants
@BenWhitehead @frankyn @tritone @anguillanneuf @yoshi-kokoro