From da9775d77bc8b1b6462d9d464a48707ea1edeb20 Mon Sep 17 00:00:00 2001 From: Gagan Gupta Date: Wed, 15 Jan 2025 14:57:32 +0530 Subject: [PATCH 1/2] docs: fixed parameter arguments for AbstractResultSet's Listener's onTransactionMetadata doc --- .../main/java/com/google/cloud/spanner/AbstractResultSet.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/google-cloud-spanner/src/main/java/com/google/cloud/spanner/AbstractResultSet.java b/google-cloud-spanner/src/main/java/com/google/cloud/spanner/AbstractResultSet.java index f9f5062d20..71c8ff44a3 100644 --- a/google-cloud-spanner/src/main/java/com/google/cloud/spanner/AbstractResultSet.java +++ b/google-cloud-spanner/src/main/java/com/google/cloud/spanner/AbstractResultSet.java @@ -48,7 +48,8 @@ abstract class AbstractResultSet extends AbstractStructReader implements Resu interface Listener { /** * Called when transaction metadata is seen. This method may be invoked at most once. If the - * method is invoked, it will precede {@link #onError(SpannerException)} or {@link #onDone()}. + * method is invoked, it will precede {@link #onError(SpannerException,boolean)} or {@link + * #onDone(boolean)}. */ void onTransactionMetadata(Transaction transaction, boolean shouldIncludeId) throws SpannerException; From db107b7ef1cebb5ed4f5f237aa1cc75df7da75f2 Mon Sep 17 00:00:00 2001 From: Gagan Gupta Date: Wed, 15 Jan 2025 15:50:37 +0530 Subject: [PATCH 2/2] style: remove unnecessary semi-colon --- .../main/java/com/google/cloud/spanner/AbstractResultSet.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/google-cloud-spanner/src/main/java/com/google/cloud/spanner/AbstractResultSet.java b/google-cloud-spanner/src/main/java/com/google/cloud/spanner/AbstractResultSet.java index 71c8ff44a3..608ccf7544 100644 --- a/google-cloud-spanner/src/main/java/com/google/cloud/spanner/AbstractResultSet.java +++ b/google-cloud-spanner/src/main/java/com/google/cloud/spanner/AbstractResultSet.java @@ -161,7 +161,7 @@ default boolean initiateStreaming(AsyncResultSet.StreamMessageListener streamMes } /** it requests the initial prefetch chunks from gRPC stream */ - default void requestPrefetchChunks() {}; + default void requestPrefetchChunks() {} } static double valueProtoToFloat64(com.google.protobuf.Value proto) {