Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow getMetadata() calls before calling next() #3111

Merged
merged 2 commits into from
May 27, 2024

Conversation

olavloite
Copy link
Collaborator

Calling getMetadata() on a MergedResultSet should be allowed without first calling next() in order to be consistent with other ResultSets that are returned by the Connection API.

Calling getMetadata() on a MergedResultSet should be allowed without
first calling next() in order to be consistent with other ResultSets
that are returned by the Connection API.
@olavloite olavloite requested a review from a team as a code owner May 17, 2024 14:59
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/java-spanner API. labels May 17, 2024
@olavloite olavloite requested a review from rahul2393 May 17, 2024 14:59
@olavloite olavloite added the owlbot:run Add this label to trigger the Owlbot post processor. label May 18, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 18, 2024
@rahul2393 rahul2393 merged commit 39902c3 into main May 27, 2024
34 checks passed
@rahul2393 rahul2393 deleted the allow-get-metadata-without-next branch May 27, 2024 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants