feat: Leader Aware Routing #2214

yifanzyifanz · 2022-12-29T23:55:54Z

Add x-goog-spanner-route-to-leader header to Spanner RPC contexts for RW/PDML transactions.

The header is added to support leader-aware-routing feature, which aims at reducing cross-regional latency for RW/PDML transactions in a multi-region instance.

This feature is off by default and can be enabled by enabling Leader Aware Routing while creating Spanner object.

Spanner spanner = SpannerOptions.newBuilder().enableLeaderAwareRouting().build().getService();

conventional-commit-lint-gcf · 2022-12-29T23:55:59Z

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

…exts for RW/PDML transactions. The header is added to support leader-aware-routing feature, which aims at reducing cross-regional latency for RW/PDML transactions in a multi-region instance.

…re routing feature

google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/GapicSpannerRpc.java

google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/SpannerRpc.java

google-cloud-spanner/src/test/java/com/google/cloud/spanner/PartitionedDmlTransactionTest.java

google-cloud-spanner/src/test/java/com/google/cloud/spanner/spi/v1/GapicSpannerRpcTest.java

...cloud-spanner/src/test/java/com/google/cloud/spanner/spi/v1/SpannerMetadataProviderTest.java

google-cloud-spanner/src/test/java/com/google/cloud/spanner/SpannerOptionsTest.java

google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerOptions.java

google-cloud-spanner/clirr-ignored-differences.xml

olavloite

LGTM, with a couple of nits.

Tip: You could add an extra verification to this test to verify that the header is really sent to Cloud Spanner:

java-spanner/google-cloud-spanner/src/test/java/com/google/cloud/spanner/ChannelUsageTest.java

Line 133 in d44e468

// Verify that the compressor name header is set.

google-cloud-spanner/src/main/java/com/google/cloud/spanner/AbstractReadContext.java

olavloite · 2023-01-27T09:58:17Z

google-cloud-spanner/src/main/java/com/google/cloud/spanner/SessionImpl.java

@@ -275,7 +275,7 @@ public AsyncTransactionManagerImpl transactionManagerAsync(TransactionOption...
  @Override
  public void prepareReadWriteTransaction() {


Not relevant for this PR, but note to self/other readers: This seems like a method that can be cleaned up. I don't think it is in use anymore. @rajatbhatta Would you mind taking a look at that?

Sure, I'll take a look. @yifanzyifanz: Please keep this comment unresolved for the time being.

google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/SpannerMetadataProvider.java

rajatbhatta

LGTM (apart from one of my pending comments and nits from @olavloite)

google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerOptions.java

rajatbhatta · 2023-01-31T04:26:49Z

google-cloud-spanner/src/main/java/com/google/cloud/spanner/SessionImpl.java

@@ -275,7 +275,7 @@ public AsyncTransactionManagerImpl transactionManagerAsync(TransactionOption...
  @Override
  public void prepareReadWriteTransaction() {


Sure, I'll take a look. @yifanzyifanz: Please keep this comment unresolved for the time being.

…eader header exists for RW transactions and does not exist for RO transactions or when the leader aware routing feature is disabled.

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

rajatbhatta

Adding "Request changes" to prevent accidental merge of this PR. Note that the changes still look good to me.

rajatbhatta · 2023-04-27T18:41:44Z

Changing the Title to make it consistent across clients.

yifanzyifanz requested a review from a team as a code owner December 29, 2022 23:55

product-auto-label bot added size: l Pull request size is large. api: spanner Issues related to the googleapis/java-spanner API. labels Dec 29, 2022

yifanzyifanz changed the title ~~Add x-goog-spanner-route-to-leader header to Spanner RPC contexts f…~~ feat: Add x-goog-spanner-route-to-leader header to Spanner RPC contexts f… Dec 29, 2022

feat: Add x-goog-spanner-route-to-leader header to Spanner RPC cont…

2cd2fbd

…exts for RW/PDML transactions. The header is added to support leader-aware-routing feature, which aims at reducing cross-regional latency for RW/PDML transactions in a multi-region instance.

yifanzyifanz force-pushed the lar branch from 0f3ca8a to 2cd2fbd Compare December 30, 2022 00:36

feat: Add knob in SpannerOptions to allow users to opt out leader awa…

b57466a

…re routing feature

yifanzyifanz requested a review from a team as a code owner January 24, 2023 21:19

yifanzyifanz and others added 2 commits January 24, 2023 13:30

Merge branch 'main' into lar

32da417

fix: fix broken tests due to the merge

cde93a3

rajatbhatta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 25, 2023

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 25, 2023

rajatbhatta suggested changes Jan 25, 2023

View reviewed changes

fix: resolve comments.

606bbda

yifanzyifanz requested review from rajatbhatta and removed request for rajatbhatta January 26, 2023 18:38

olavloite approved these changes Jan 27, 2023

View reviewed changes

rajatbhatta approved these changes Jan 31, 2023

View reviewed changes

yifanzyifanz and others added 3 commits February 1, 2023 12:56

Merge branch 'googleapis:main' into lar

0156457

fix: resolve comments and add new tests to verify that the route-to-l…

1bbd24d

…eader header exists for RW transactions and does not exist for RO transactions or when the leader aware routing feature is disabled.

fix: Update comments for SpannerOptions.disableLeaderAwareRouting

f9152cd

rajatbhatta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 2, 2023

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 2, 2023

rajatbhatta added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 3, 2023

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 3, 2023

gcf-owl-bot bot and others added 2 commits February 3, 2023 03:19

🦉 Updates from OwlBot post-processor

90d455c

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Merge branch 'main' into lar

b1d44ce

rajatbhatta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 3, 2023

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 3, 2023

rajatbhatta added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 3, 2023

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 3, 2023

rajatbhatta added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 3, 2023

rajatbhatta suggested changes Feb 6, 2023

View reviewed changes

Merge branch 'main' into lar

c5d34ab

rajatbhatta mentioned this pull request Feb 27, 2023

feat: Leader Aware Routing in Connection API #2308

Merged

yifanzyifanz and others added 2 commits April 20, 2023 23:03

feat: Disable leader aware routing by default for public preview

9c212af

Merge branch 'main' into lar

426265d

rajatbhatta removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 27, 2023

rajatbhatta approved these changes Apr 27, 2023

View reviewed changes

rajatbhatta changed the title ~~feat: Add x-goog-spanner-route-to-leader header to Spanner RPC contexts f…~~ feat: Leader Aware Routing Apr 27, 2023

rajatbhatta added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 27, 2023

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 27, 2023

rajatbhatta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 28, 2023

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 28, 2023

rajatbhatta merged commit 9695ace into googleapis:main Apr 28, 2023

release-please bot mentioned this pull request Apr 28, 2023

chore(main): release 6.41.0 #2397

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Leader Aware Routing #2214

feat: Leader Aware Routing #2214

yifanzyifanz commented Dec 29, 2022 •

edited by rajatbhatta

Loading

conventional-commit-lint-gcf bot commented Dec 29, 2022 •

edited

Loading

olavloite left a comment

olavloite Jan 27, 2023

rajatbhatta Jan 31, 2023 •

edited

Loading

rajatbhatta left a comment •

edited

Loading

rajatbhatta Jan 31, 2023 •

edited

Loading

rajatbhatta left a comment

rajatbhatta commented Apr 27, 2023

		@@ -275,7 +275,7 @@ public AsyncTransactionManagerImpl transactionManagerAsync(TransactionOption...
		@Override
		public void prepareReadWriteTransaction() {

feat: Leader Aware Routing #2214

feat: Leader Aware Routing #2214

Conversation

yifanzyifanz commented Dec 29, 2022 • edited by rajatbhatta Loading

conventional-commit-lint-gcf bot commented Dec 29, 2022 • edited Loading

olavloite left a comment

Choose a reason for hiding this comment

olavloite Jan 27, 2023

Choose a reason for hiding this comment

rajatbhatta Jan 31, 2023 • edited Loading

Choose a reason for hiding this comment

rajatbhatta left a comment • edited Loading

Choose a reason for hiding this comment

rajatbhatta Jan 31, 2023 • edited Loading

Choose a reason for hiding this comment

rajatbhatta left a comment

Choose a reason for hiding this comment

rajatbhatta commented Apr 27, 2023

yifanzyifanz commented Dec 29, 2022 •

edited by rajatbhatta

Loading

conventional-commit-lint-gcf bot commented Dec 29, 2022 •

edited

Loading

rajatbhatta Jan 31, 2023 •

edited

Loading

rajatbhatta left a comment •

edited

Loading

rajatbhatta Jan 31, 2023 •

edited

Loading