-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(spanner): add samples for fine grained access control #2172
Conversation
Here is the summary of changes. You are about to add 4 region tags.
This comment is generated by snippet-bot.
|
@rahul2393: I think we should add integration tests for the samples similar to https://github.com/googleapis/java-spanner/pull/2007/files#diff-cbbf8310726971f9d351d2727d761558fcea52286bd9b86628e83e763f8b63f0. Please add |
samples/snippets/src/main/java/com/example/spanner/AddAndDropDatabaseRole.java
Outdated
Show resolved
Hide resolved
samples/snippets/src/main/java/com/example/spanner/AddAndDropDatabaseRole.java
Outdated
Show resolved
Hide resolved
samples/snippets/src/main/java/com/example/spanner/AddAndDropDatabaseRole.java
Outdated
Show resolved
Hide resolved
samples/snippets/src/main/java/com/example/spanner/AddAndDropDatabaseRole.java
Outdated
Show resolved
Hide resolved
samples/snippets/src/main/java/com/example/spanner/EnableFineGrainedAccess.java
Outdated
Show resolved
Hide resolved
samples/snippets/src/main/java/com/example/spanner/EnableFineGrainedAccess.java
Outdated
Show resolved
Hide resolved
samples/snippets/src/main/java/com/example/spanner/ListDatabaseRoles.java
Outdated
Show resolved
Hide resolved
samples/snippets/src/main/java/com/example/spanner/ListDatabaseRoles.java
Outdated
Show resolved
Hide resolved
samples/snippets/src/main/java/com/example/spanner/EnableFineGrainedAccess.java
Outdated
Show resolved
Hide resolved
samples/snippets/src/main/java/com/example/spanner/ReadDataWithDatabaseRole.java
Outdated
Show resolved
Hide resolved
samples/snippets/src/main/java/com/example/spanner/ListDatabaseRoles.java
Outdated
Show resolved
Hide resolved
samples/snippets/src/main/java/com/example/spanner/AddAndDropDatabaseRole.java
Outdated
Show resolved
Hide resolved
samples/snippets/src/main/java/com/example/spanner/EnableFineGrainedAccess.java
Outdated
Show resolved
Hide resolved
samples/snippets/src/main/java/com/example/spanner/EnableFineGrainedAccess.java
Outdated
Show resolved
Hide resolved
samples/snippets/src/main/java/com/example/spanner/EnableFineGrainedAccess.java
Outdated
Show resolved
Hide resolved
samples/snippets/src/main/java/com/example/spanner/AddAndDropDatabaseRole.java
Outdated
Show resolved
Hide resolved
samples/snippets/src/main/java/com/example/spanner/AddAndDropDatabaseRole.java
Outdated
Show resolved
Hide resolved
samples/snippets/src/main/java/com/example/spanner/EnableFineGrainedAccess.java
Outdated
Show resolved
Hide resolved
samples/snippets/src/main/java/com/example/spanner/ReadDataWithDatabaseRole.java
Outdated
Show resolved
Hide resolved
samples/snippets/src/main/java/com/example/spanner/EnableFineGrainedAccess.java
Outdated
Show resolved
Hide resolved
samples/snippets/src/main/java/com/example/spanner/ListDatabaseRoles.java
Outdated
Show resolved
Hide resolved
077afcc
to
d4ad45f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm in general, just a couple of comments. You can merge it once the tests pass post those changes.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.
EnableFineGrainedAccess sample requires service account to work, so skipping integration tests for the same.