Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support for spanner external host #1884

Merged
merged 2 commits into from
Jan 8, 2025
Merged

feat: support for spanner external host #1884

merged 2 commits into from
Jan 8, 2025

Conversation

sagnghos
Copy link
Contributor

@sagnghos sagnghos commented Jan 8, 2025 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@sagnghos sagnghos requested a review from a team as a code owner January 8, 2025 06:09
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: spanner Issues related to the googleapis/java-spanner-jdbc API. labels Jan 8, 2025
@olavloite olavloite changed the title feat(spanner): jdbc support for spanner external host feat: support for spanner external host Jan 8, 2025
@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 8, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 8, 2025
olavloite
olavloite reviewed Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@olavloite olavloite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests to verify that the new format works (I know it does, but not having tests for it risks regressions if someone accidentally removes it in the future).

@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Jan 8, 2025
@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 8, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 8, 2025
@sagnghos sagnghos changed the title feat: support for spanner external host feat(spanner): support for spanner external host Jan 8, 2025
@sagnghos sagnghos changed the title feat(spanner): support for spanner external host feat: support for spanner external host Jan 8, 2025
@olavloite olavloite merged commit 123a7bc into googleapis:main Jan 8, 2025
22 checks passed
@release-please release-please bot mentioned this pull request Jan 8, 2025
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Jan 11, 2025
@release-please
chore(main): release 2.26.0 (#1885)
0ac1283 
🤖 I have created a release *beep* *boop*
---


## [2.26.0](https://togithub.com/googleapis/java-spanner-jdbc/compare/v2.25.3...v2.26.0) (2025-01-11)


### Features

* Support for spanner external host ([#1884](https://togithub.com/googleapis/java-spanner-jdbc/issues/1884)) ([123a7bc](https://togithub.com/googleapis/java-spanner-jdbc/commit/123a7bcd9825b20bfbf7e9b057c2bd0f5213cac3))


### Dependencies

* Update dependency com.google.api.grpc:proto-google-cloud-trace-v1 to v2.56.0 ([#1887](https://togithub.com/googleapis/java-spanner-jdbc/issues/1887)) ([2016d9c](https://togithub.com/googleapis/java-spanner-jdbc/commit/2016d9c47a5c6d12ba101827fe933c3ddd334e78))
* Update dependency com.google.cloud:google-cloud-spanner-bom to v6.85.0 ([#1889](https://togithub.com/googleapis/java-spanner-jdbc/issues/1889)) ([3424d38](https://togithub.com/googleapis/java-spanner-jdbc/commit/3424d382a89b33d0870b00f04fd10dafa62bcc3d))
* Update dependency com.google.cloud:google-cloud-trace to v2.56.0 ([#1888](https://togithub.com/googleapis/java-spanner-jdbc/issues/1888)) ([ce78b18](https://togithub.com/googleapis/java-spanner-jdbc/commit/ce78b188e70f30776e58a1e3a7d8c4b1559e4d68))
* Update dependency com.google.cloud:sdk-platform-java-config to v3.41.1 ([#1886](https://togithub.com/googleapis/java-spanner-jdbc/issues/1886)) ([73eacc6](https://togithub.com/googleapis/java-spanner-jdbc/commit/73eacc66bacfd5c367f764ed3db805309cb0d1c8))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olavloite olavloite olavloite approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/java-spanner-jdbc API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sagnghos @olavloite @yoshi-kokoro