feat: support float32 #1518
Merged
feat: support float32 #1518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for the FLOAT32 / real data type.
product-auto-label
bot
added
size: l
product-auto-label
bot
added
size: xl
olavloite
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
olavloite
commented
Mar 5, 2024
| parameters.setParameter(parameterIndex, value, Types.FLOAT); | ||
| parameters.setParameter(parameterIndex, value, Types.REAL); |
There was a problem hiding this comment.
Types.FLOAT is a synonym for Types.DOUBLE in JDBC. Both represent a 64-bit floating point value. Types.REAL is the type code that should be used for 32-bit floating point values.
arawind
approved these changes
Mar 7, 2024
src/main/java/com/google/cloud/spanner/jdbc/JdbcParameterStore.java
Outdated
Show resolved
Hide resolved
src/test/java/com/google/cloud/spanner/jdbc/JdbcParameterStoreTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/google/cloud/spanner/jdbc/it/ITJdbcPgNumericTest.java
Outdated
Show resolved
Hide resolved
product-auto-label
bot
added
size: l
olavloite
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the FLOAT32 / real data type.