Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Maven profile for Airlock #928

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented Nov 11, 2024

b/356854847

I confirmed the behavior by locally installing the java-shared-config ( T=$(mktemp -d) && rm -rf $T/* && mvn -Dmaven.repo.local=$T install) and created an example project that inherits the pom.xml (https://gist.github.com/suztomo/afaa743fdcfbd86d79369d8d9bfc591e):

  <parent>
    <groupId>com.google.cloud</groupId>
    <artifactId>google-cloud-shared-config</artifactId>
    <version>1.11.3</version>
  </parent>
...

  <dependencies>
    <dependency>
      <groupId>com.google.guava</groupId>
      <artifactId>guava</artifactId>
      <version>33.3.1-jre</version>
    </dependency>
...

I ran the Maven command. I observed that the dependencies come from the specified artifact registry URL:

~/airlock-use-example $  mvn -Dmaven.repo.local=$T clean install -DskipTests -Pairlock-trusted  -Dcheckstyle.skip 
...
Downloading from airlock: artifactregistry://us-maven.pkg.dev/artifact-foundry-prod/maven-3p-trusted/org/checkerframework/checker-qual/3.43.0/checker-qual-3.43.0.pom
[INFO] Initializing Credentials...
[INFO] Application Default Credentials unavailable.
[INFO] Using credentials retrieved from gcloud.
[INFO] Refreshing Credentials...
Downloaded from airlock: artifactregistry://us-maven.pkg.dev/artifact-foundry-prod/maven-3p-trusted/org/checkerframework/checker-qual/3.43.0/checker-qual-3.43.0.pom (2.1 kB at 603 B/s)
Downloading from airlock: artifactregistry://us-maven.pkg.dev/artifact-foundry-prod/maven-3p-trusted/org/checkerframework/checker-qual/3.43.0/checker-qual-3.43.0.jar
Downloaded from airlock: artifactregistry://us-maven.pkg.dev/artifact-foundry-prod/maven-3p-trusted/org/checkerframework/checker-qual/3.43.0/checker-qual-3.43.0.jar (232 kB at 94 kB/s)

(checker-qual is a dependency of guava)

@suztomo suztomo requested a review from a team as a code owner November 11, 2024 22:16
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Nov 11, 2024
@suztomo suztomo merged commit 10da584 into googleapis:main Nov 12, 2024
59 checks passed
@suztomo suztomo deleted the airlock-config branch November 12, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants