-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update graal-sdk to 24 and graalvm-A to 21.x #815
Conversation
In JDK 21,
However, the same test passes in JDK 11. |
Created issue to track ITHttpAnnotation failure in googleapis/sdk-platform-java#2695 |
According to the graal/sdk CHANGELOG, the GraalVM SDK was split into smaller modules and the use of graal-sdk is deprecated. The new maven configuration to customize native image generation is:
java-spanner's pom needs to be updated to ignore the provided |
Do not merge until googleapis/sdk-platform-java#2695 is resolved |
@mpeddada1 : Do you agree this can now be merged? |
Following up on #815 (comment), looked into adding the maven-dependency-plugin settings to native-image-shared-config in #815 (comment) but these settings end up getting overridden by the child pom so it doesn't address the issue we are facing with java-spanner. Current approach: Add ignoreDependencies property in |
Also verified locally with java-kms (logs).
Noting two significant changes in PR:
- TheITHttpAnnotation test fails with HttpResponseException in JDK 21 sdk-platform-java#2695 has been fixed so we proceeded to keep this test in.ITHttpAnnotation
test is marked as skipped in the showcase downstream check until ITHttpAnnotation test fails with HttpResponseException in JDK 21 sdk-platform-java#2695 is fixed.org.graalvm.sdk:nativeimage
being unaccounted for in theignoredDependencies
section of java-spanner'smaven-dependency-plugin
. We plan temporarily mark this check as optional to proceed with the update and includeorg.graalvm.sdk:nativeimage
in the maven-dependency-plugin oncesdk-platform-java-config
has been updated in the repo. See feat: update graal-sdk to 24 and graalvm-A to 21.x #815 (comment) for context.