Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement downstream check to catch failing dependency updates #790

Open
alicejli opened this issue Mar 15, 2024 · 2 comments · May be fixed by #795
Open

Implement downstream check to catch failing dependency updates #790

alicejli opened this issue Mar 15, 2024 · 2 comments · May be fixed by #795
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@alicejli
Copy link
Contributor

This dependency update: #772

caused a downstream failure that was only caught when trying to merge the updated shared-config: googleapis/sdk-platform-java#2571 (comment)

There should be some downstream checks in java-shared-config that can catch these types of failures at the time the dependency update is introduced.
@alicejli alicejli added priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Mar 15, 2024
@suztomo
Copy link
Member

suztomo commented Mar 15, 2024 •
edited
Loading

The checks are there.

image

It's either

Looking forward to your findings.

@burkedavison
Copy link
Member

The compatibility problem occurs only with the two spanner repos.

Our java-shared-config downstream checks perform some second-generation-downstream checking as Tomo showed above (bigtable, bigquery), but we aren't fully exercising the full second-generation downstream check fanout. We could add spanner to this repo's list of checks, though, since we know it has shown unique behavior.

("second generation downstream check" == "grandchild repo check")

@alicejli alicejli linked a pull request Mar 20, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: add all handwritten repos to downstream check googleapis/java-shared-config
3 participants
@suztomo @burkedavison @alicejli