Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add junit-vintage dep to avoid skipping post-compilation native tests #586

Merged
merged 2 commits into from
May 30, 2023

Conversation

mpeddada1
Copy link
Contributor

@mpeddada1 mpeddada1 commented Apr 17, 2023

In a test run conducted with java-pubsub, we see that after the native image generation phase, we end up with 0 tests being executed:

Finished generating 'native-tests' in 57.7s.
[INFO] Executing: /usr/local/google/home/mpeddada/IdeaProjects/native-image-experiments/graalvm23-update-submodule/java-pubsub/google-cloud-pubsub/target/native-tests --xml-output-dir /usr/local/google/home/mpeddada/IdeaProjects/native-image-experiments/graalvm23-update-submodule/java-pubsub/google-cloud-pubsub/target/native-test-reports -Djunit.platform.listeners.uid.tracking.output.dir=/usr/local/google/home/mpeddada/IdeaProjects/native-image-experiments/graalvm23-update-submodule/java-pubsub/google-cloud-pubsub/target/test-ids
JUnit Platform on Native Image - report
----------------------------------------
 
 
Test run finished after 3 ms
[         1 containers found      ]
[         0 containers skipped    ]
[         1 containers started    ]
[         0 containers aborted    ]
[         1 containers successful ]
[         0 containers failed     ]
[         0 tests found           ]
[         0 tests skipped         ]
[         0 tests started         ]
[         0 tests aborted         ]
[         0 tests successful      ]
[         0 tests failed          ]

Reproducer: https://github.com/mpeddada1/graalvm23-skipped-tests

As demonstrated in the reproducer, the junit-vintage-engine dependency is needed to be added to resolve this issue.

TODO:

  • Modify the downstream test to use monorepo instead of the old org-policy repo.

@mpeddada1 mpeddada1 requested a review from a team as a code owner April 17, 2023 18:56
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Apr 17, 2023
@mpeddada1 mpeddada1 merged commit f6e6f69 into main May 30, 2023
@mpeddada1 mpeddada1 deleted the add-junit-vintage branch May 30, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants