This repository has been archived by the owner on Sep 16, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 18
docs(sample): Add sample for Native Image Support #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
api: secretmanager
Issues related to the googleapis/java-secretmanager API.
samples
Issues that are directly related to samples.
labels
Feb 28, 2022
Warning: This pull request is touching the following templated files:
|
…manager into add-native-sample
suztomo
reviewed
Mar 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The newly-added integration test is not shown in "Kokoro - Test: Samples" https://source.cloud.google.com/results/invocations/0a560e5f-f023-468b-a0c3-ea928e4df001.
private static final String NATIVE_TEST_SECRET_ID = "native-test-secret" + UUID.randomUUID(); | ||
private static String PROJECT_ID = ServiceOptions.getDefaultProjectId(); | ||
private ByteArrayOutputStream bout; | ||
private PrintStream out; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My intelliJ told me that this variable is unnecessary.
suztomo
approved these changes
Mar 2, 2022
Quick note: For now, the sample will be run as part of the nightly builds (similar to how samples in snippets/ are run). We can revisit this to see if we want add this sample to the presubmit build. |
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Mar 30, 2022
🤖 I have created a release *beep* *boop* --- ### [2.1.4](v2.1.3...v2.1.4) (2022-03-29) ### Documentation * **sample:** Add sample for Native Image Support ([#711](#711)) ([1afd3aa](1afd3aa)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.9.0 ([#739](#739)) ([6a58447](6a58447)) * update dependency com.google.cloud:native-image-support to v0.12.10 ([#731](#731)) ([3e9211a](3e9211a)) * update dependency com.google.cloud:native-image-support to v0.12.11 ([#738](#738)) ([afe2969](afe2969)) * update dependency com.google.cloud:native-image-support to v0.12.6 ([#723](#723)) ([a2803ca](a2803ca)) * update dependency com.google.cloud:native-image-support to v0.12.7 ([#727](#727)) ([fa8e4ed](fa8e4ed)) * update dependency com.google.cloud:native-image-support to v0.12.8 ([#729](#729)) ([1a9d2b8](1a9d2b8)) * update dependency com.google.cloud:native-image-support to v0.12.9 ([#730](#730)) ([60e8336](60e8336)) * update dependency org.graalvm.buildtools:junit-platform-native to v0.9.10 ([#724](#724)) ([604a9bc](604a9bc)) * update dependency org.graalvm.buildtools:junit-platform-native to v0.9.11 ([#735](#735)) ([6123ddc](6123ddc)) * update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.10 ([#725](#725)) ([6a71213](6a71213)) * update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.11 ([#736](#736)) ([d54de52](d54de52)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
api: secretmanager
Issues related to the googleapis/java-secretmanager API.
samples
Issues that are directly related to samples.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR copies over the SecretManager sample, Setup Instructions and README for native image support from GoogleCloudPlatform/native-image-support-java. It also adds an integration test that can be run as a native image.
Calling
mvn package -Pnative -DskipTests
builds the native image for the application and callingmvn test -Pnative
runs the test as a native image.For more information: https://graalvm.github.io/native-build-tools/latest/maven-plugin.html#configuration