Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: report connector package version instead of kafka connect version #266

Merged
merged 2 commits into from
Jun 18, 2024
Merged

fix: report connector package version instead of kafka connect version #266

merged 2 commits into from
Jun 18, 2024

Conversation

HurSungYun
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #249

Referenced from https://github.com/confluentinc/kafka-connect-bigquery/blob/986b1be57add8bc842f31168c308fd15ccf05bf4/kcbq-connector/src/main/java/com/wepay/kafka/connect/bigquery/utils/Version.java#L30

I believe it's okay to copy that code because of Apache License. Let me know if there's a problem with it.

@HurSungYun HurSungYun requested a review from a team as a code owner May 26, 2023 10:42
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label May 26, 2023
samarthsingal
samarthsingal approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@samarthsingal samarthsingal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@HurSungYun
Copy link
Contributor Author

HurSungYun commented Jun 1, 2023 •
edited
Loading

@samarthsingal thank you for reviewing this PR.

I've fixed lint errors by running mvn com.coveo:fmt-maven-plugin:format.

@samarthsingal samarthsingal added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 13, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 13, 2023
@samarthsingal samarthsingal added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 14, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 14, 2024
@samarthsingal samarthsingal added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 18, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 18, 2024
@samarthsingal samarthsingal added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 18, 2024
@samarthsingal samarthsingal merged commit 33f2761 into googleapis:main Jun 18, 2024
2 of 5 checks passed
@release-please release-please bot mentioned this pull request Jun 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samarthsingal samarthsingal samarthsingal approved these changes

Assignees
No one assigned
Labels
kokoro:run Add this label to force Kokoro to re-run the tests. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Connectors version is reported incorrectly
3 participants
@HurSungYun @samarthsingal @yoshi-kokoro